UnvalidatedDynamicMethodCall query does not detect flow inside try/catch

未关闭
#20,098 3 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

还没有人认领这个 Issue。

评估

难度
4/5
预计耗时
3-5 天
新手友好度
35/100
Issue 类型
缺陷
描述清晰度
基本清楚
活跃度
停滞
技术栈
express, javascript
领域
security

调研方向

从 UnvalidatedDynamicMethodCall 查询开始，并复现 issue 中链接的训练挑战。比较使用 req.params.action 的 Express 路由在 arrow-function 处理程序中有无 try/catch 时的情况，然后确认在 issue 修复后可以检测到存在漏洞的动态调用。

由索引模型根据 Issue 内容生成。

描述

question

Hi CodeQL team 👋

I'm currently building some training challenges for developers to help them identify insecure dynamic method calls. I designed one of the exercises based on the UnvalidatedDynamicMethodCall alert.

However, I noticed that the vulnerability I created was not detected by the query. After a lot of debugging, I suspect the query does not handle taint flow properly when the logic is inside arrow functions.

  • The vulnerable code uses an Express route with an arrow function as the handler.
  • Inside the arrow function, I access req.params.action and use it to dynamically invoke a method: userManager[action](...).
  • This allows access to both regular and admin-only methods of the userManager object.

Unfortunately, this pattern wasn't flagged by the query, even though it's clearly unsafe.

I'm still learning how CodeQL queries work, and I'm not very experienced with the query language yet. I'd really appreciate any help understanding why this scenario is missed, and how I might contribute a feature for it.

I'd love to open a PR — just need some guidance on how to proceed the right way.

update: I have tested here like @rvermeulen said and the catch is the try/catch.

git blaming cc: @asgerf

主要语言
CodeQL
星标
10.1k
派生
2.1k
平均合并
2 天 10 小时
30 天内合并 PR
134

贡献指南

打开贡献指南

从这里开始

  1. 先读完整个 Issue，再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库，在一个分支上完成修改。
  4. 提交 Pull Request，并在描述里引用这个 Issue 编号。

github/codeql 的其他 Issue

查看 github/codeql 的全部 Issue

相似的 Issue

更多 Security Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。