`DCL51-CPP`: Only reserve function names when used within the global namespace

未关闭

#148 创建于 2022年11月28日 5 条评论 0 个 reaction 已指派 1 人在 GitHub 查看

@lcartey 已经在做这个了。

开始于 2024年1月14日。

评估

这个 Issue 还没有评估数据。

描述

Difficulty-High false positive/false negative Impact-High Stardard-CERT-C++ user-report

Affected rules

DCL51-CPP

Description

The rule currently enforces that function names defined in standard library headers are not reused in any namespace. However, a careful re-reading of the C++ standard suggests that's overly specific. [reserved.names] specifically states that the only kinds of name that are reserved are macros, "global names" and "names with external linkage". In [extern.names], the standard says:

Each global function signature declared with external linkage in a header is reserved to the implementation to designate that function signature with external linkage.

So only global function signatures are reserved, and only where they have external linkage. I think we need to do the following:

Apply only to the global namespace
Filter list of reserved function names by those that appear in the global namespace and have external linkage (this may already be the case).
Match function signatures (I believe it is valid to reuse the name as long as the signature is different).

We may also need to review the rules for objects and _ prefixes.

Example

namespace MyNamespace {
  void all_of(); // COMPLIANT
}

主要语言: CodeQL
星标: 227
派生: 82
平均合并: 6 天 7 小时
30 天内合并 PR: 9

贡献指南

打开贡献指南

从这里开始

先读完整个 Issue，再读项目的贡献指南。
在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
Fork 仓库，在一个分支上完成修改。
提交 Pull Request，并在描述里引用这个 Issue 编号。

github/codeql-coding-standards 的其他 Issue

`RULE-10-0-1`: Structured bindings should not be reported as violations 未关闭

false positive/false negative Stardard-MISRA-C++

难度 2/5 1-3 小时新手友好度 72/100

github/codeql-coding-standards#1172 · 2026年8月5日创建
`RULE-10-4`: False negatives as rule does not currently consider ternaries 未关闭

Difficulty-Low false positive/false negative false-negative Impact-Low Standard-MISRA-C

难度 2/5 1-3 小时新手友好度 68/100

github/codeql-coding-standards#821 · 2024年12月12日创建
`EXP39-C`: False positives related to compatible types, harmless casts 未关闭

Difficulty-Medium false positive/false negative false-positive Impact-Medium Standard-CERT-C

难度 4/5 3-5 天新手友好度 48/100

github/codeql-coding-standards#1200 · 2026年9月20日创建
`RULE-0-0-1`: "unreachable statement" false positives due to over-pruning of the control-flow graph 未关闭

false positive/false negative

难度 4/5 3-5 天新手友好度 48/100

github/codeql-coding-standards#1190 · 2026年8月28日创建
`RULE-0-1-1`: Findings should be suppressed for [[maybe_unused]] initialization 未关闭

false positive/false negative

难度 3/5 1-2 天新手友好度 65/100

github/codeql-coding-standards#1175 · 2026年8月20日创建

查看 github/codeql-coding-standards 的全部 Issue