`DCL51-CPP`: Only reserve function names when used within the global namespace

未關閉

#148 建立於 2022年11月28日 5 則留言 0 個 reaction 已指派 1 人在 GitHub 檢視

@lcartey 已經在處理了。

開始於 2024年1月14日。

評估

這個 Issue 還沒有評估資料。

描述

Difficulty-High false positive/false negative Impact-High Stardard-CERT-C++ user-report

Affected rules

DCL51-CPP

Description

The rule currently enforces that function names defined in standard library headers are not reused in any namespace. However, a careful re-reading of the C++ standard suggests that's overly specific. [reserved.names] specifically states that the only kinds of name that are reserved are macros, "global names" and "names with external linkage". In [extern.names], the standard says:

Each global function signature declared with external linkage in a header is reserved to the implementation to designate that function signature with external linkage.

So only global function signatures are reserved, and only where they have external linkage. I think we need to do the following:

Apply only to the global namespace
Filter list of reserved function names by those that appear in the global namespace and have external linkage (this may already be the case).
Match function signatures (I believe it is valid to reuse the name as long as the signature is different).

We may also need to review the rules for objects and _ prefixes.

Example

namespace MyNamespace {
  void all_of(); // COMPLIANT
}

主要語言: CodeQL
星號: 227
分支: 82
平均合併: 6 天 7 小時
30 天內合併 PR: 9

貢獻指南

開啟貢獻指南

從這裡開始

先讀完整個 Issue，再讀專案的貢獻指南。
在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
Fork 儲存庫，在一個分支上完成修改。
送出 Pull Request，並在描述裡引用這個 Issue 編號。

github/codeql-coding-standards 的其他 Issue

`RULE-10-0-1`: Structured bindings should not be reported as violations 未關閉

false positive/false negative Stardard-MISRA-C++

難度 2/5 1-3 小時新手友好度 72/100

github/codeql-coding-standards#1172 · 2026年8月5日建立
`RULE-10-4`: False negatives as rule does not currently consider ternaries 未關閉

Difficulty-Low false positive/false negative false-negative Impact-Low Standard-MISRA-C

難度 2/5 1-3 小時新手友好度 68/100

github/codeql-coding-standards#821 · 2024年12月12日建立
`EXP39-C`: False positives related to compatible types, harmless casts 未關閉

Difficulty-Medium false positive/false negative false-positive Impact-Medium Standard-CERT-C

難度 4/5 3-5 天新手友好度 48/100

github/codeql-coding-standards#1200 · 2026年9月20日建立
`RULE-0-0-1`: "unreachable statement" false positives due to over-pruning of the control-flow graph 未關閉

false positive/false negative

難度 4/5 3-5 天新手友好度 48/100

github/codeql-coding-standards#1190 · 2026年8月28日建立
`RULE-0-1-1`: Findings should be suppressed for [[maybe_unused]] initialization 未關閉

false positive/false negative

難度 3/5 1-2 天新手友好度 65/100

github/codeql-coding-standards#1175 · 2026年8月20日建立

查看 github/codeql-coding-standards 的全部 Issue