Renamed or removed Environments are sent DELETE requests in nop mode
维护者通常 2 天内回复
还没有人认领这个 Issue。
评估
- 难度
- 4/5
- 预计耗时
- 3-5 天
- 新手友好度
- 35/100
- Issue 类型
- 缺陷
- 描述清晰度
- 基本清楚
- 活跃度
- 停滞
- 技术栈
- javascript
调研方向
跟踪 pull request check runs 的 nop-mode 处理,并了解重命名或移除的 environment 如何到达 environment REST endpoint。使用报告的日志和预期行为作为完成检查,确认当 environment 不在配置中时,no-op 路径不会发送 DELETE 请求。
由索引模型根据 Issue 内容生成。
描述
Problem Description
As per the title, when Environments are renamed or removed entirely in the config and the app is executed in nop mode via a pull request check run, the environment will be deleted from the associated repositories.
What is actually happening
As per the title, when Environments are renamed or removed entirely in the config and the app is executed in nop mode via a pull request check run, the environment REST endpoint will be sent a DELETE request.
What is the expected behavior
In nop mode no changes should be made to repository settings.
Error output, if available
Not errors, but these logs were generated on a no-op dry run of safe-settings where balena-staging.com+sign-api-key had been deleted from the settings.
{"level":20,"time":1740682249048,"pid":24,"hostname":"safe-settings-d86c9d9d7-bwdrd","name":"probot","name":"probot","name":"octokit","msg":"GitHub request: DELETE https://api.github.com/repos/balena-os/balena-iot-gate-imx8plus/environments/balena-staging.com%2Bsign-api-key - 204"}
2025-02-27 13:50:48.103
{"level":20,"time":1740682248103,"pid":24,"hostname":"safe-settings-d86c9d9d7-bwdrd","name":"probot","name":"probot","name":"octokit","msg":"GitHub request: DELETE https://api.github.com/repos/balena-os/balena-iot-gate-imx8plus/environments/balena-cloud.com%2Bsign-api-key - 204"}
2025-02-27 13:50:41.042
{"level":20,"time":1740682241041,"pid":24,"hostname":"safe-settings-d86c9d9d7-bwdrd","name":"probot","name":"probot","name":"octokit","msg":"GitHub request: DELETE https://api.github.com/repos/balena-os/balena-iot-gate-imx8/environments/balena-staging.com%2Bsign-api-key - 204"}
Context
Are you using the hosted instance of probot/settings or running your own?
Self-hosted
If running your own instance, are you using it with github.com or GitHub Enterprise?
github.com
Version of probot/settings
We previously thought this issue had been addressed here: https://github.com/github/safe-settings/pull/691
Last reproduced in https://github.com/github/safe-settings/releases/tag/2.1.16
Version of GitHub Enterprise
- 主要语言
- JavaScript
- 星标
- 942
- 派生
- 238
- PR 合并指标
- 30 天内没有已合并 PR
环境准备
在浏览器里用你自己的 GitHub 账号启动这个项目的开发容器。
- 提供 Dockerfile 或 Docker Compose 文件
- 没有 Pull Request 模板
- 阅读贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
github-community-projects/safe-settings 的其他 Issue
-
Teams: teams with organization-role access show up as deletions可能已有人在做 @TovaBecker 于 1 天前认领。 未关闭
难度 2/5 1-3 小时 新手友好度 83/100
github-community-projects/safe-settings#1144 ·
维护者通常 2 天内回复
-
难度 2/5 1-3 小时 新手友好度 78/100
github-community-projects/safe-settings#1143 ·
维护者通常 2 天内回复
-
难度 2/5 1-3 小时 新手友好度 78/100
github-community-projects/safe-settings#1135 ·
维护者通常 2 天内回复
-
难度 2/5 1-3 小时 新手友好度 76/100
github-community-projects/safe-settings#1134 ·
维护者通常 2 天内回复
-
environments: additive_plugins is ignored, undeclared environments are deleted可能已有人在做 @yaunj 于 12 天前认领。 未关闭
难度 2/5 1-3 小时 新手友好度 78/100
github-community-projects/safe-settings#1133 ·
维护者通常 2 天内回复
查看 github-community-projects/safe-settings 的全部 Issue
相似的 Issue
-
难度 2/5 1-3 小时 新手友好度 72/100
cytoscape/cytoscape.js#3597 ·
维护者通常 5 天内回复
-
priority: low server testing
难度 1/5 1 小时以内 新手友好度 88/100
blamechris/chroxy#9277 ·
维护者通常 1 天内回复
-
难度 1/5 1 小时以内 新手友好度 72/100
sunososobro-hub/cloudball#191 ·
维护者通常 1 天内回复
-
[MCP]: page snapshots in .playwright-mcp/ are not git-ignored (.playwright-cli/ is, since #42318)未关闭
难度 2/5 1-3 小时 新手友好度 62/100
microsoft/playwright#44289 ·
维护者通常 1 天内回复
-
area:post effort:low enhancement P7 source:agent
难度 2/5 1-3 小时 新手友好度 68/100
维护者通常 1 天内回复