Renamed or removed Environments are sent DELETE requests in nop mode

Ouverte
#799 1 commentaire 1 réaction 0 personnes assignées Voir sur GitHub

Les mainteneurs répondent en général sous 2 jours

Personne n'a encore pris cette issue.

Évaluation

Difficulté
4/5
Temps estimé
3-5 jours
Accessibilité débutants
35/100
Type d'issue
Bug
Clarté
Plutôt claire
Activité
À l'abandon
Stack technique
javascript
Domaine
api, backend

Piste de recherche

Suivez le traitement de nop-mode pour les check runs de pull request et déterminez comment les environnements renommés ou supprimés atteignent l’endpoint REST de environment. Confirmez, en utilisant les logs signalés et le comportement attendu comme vérification d’achèvement, que le chemin no-op n’envoie pas de requêtes DELETE lorsque les environnements sont absents de la configuration.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Description

bug

Problem Description

As per the title, when Environments are renamed or removed entirely in the config and the app is executed in nop mode via a pull request check run, the environment will be deleted from the associated repositories.

What is actually happening

As per the title, when Environments are renamed or removed entirely in the config and the app is executed in nop mode via a pull request check run, the environment REST endpoint will be sent a DELETE request.

What is the expected behavior

In nop mode no changes should be made to repository settings.

Error output, if available

Not errors, but these logs were generated on a no-op dry run of safe-settings where balena-staging.com+sign-api-key had been deleted from the settings.

{"level":20,"time":1740682249048,"pid":24,"hostname":"safe-settings-d86c9d9d7-bwdrd","name":"probot","name":"probot","name":"octokit","msg":"GitHub request: DELETE https://api.github.com/repos/balena-os/balena-iot-gate-imx8plus/environments/balena-staging.com%2Bsign-api-key - 204"}
2025-02-27 13:50:48.103	
{"level":20,"time":1740682248103,"pid":24,"hostname":"safe-settings-d86c9d9d7-bwdrd","name":"probot","name":"probot","name":"octokit","msg":"GitHub request: DELETE https://api.github.com/repos/balena-os/balena-iot-gate-imx8plus/environments/balena-cloud.com%2Bsign-api-key - 204"}
2025-02-27 13:50:41.042	
{"level":20,"time":1740682241041,"pid":24,"hostname":"safe-settings-d86c9d9d7-bwdrd","name":"probot","name":"probot","name":"octokit","msg":"GitHub request: DELETE https://api.github.com/repos/balena-os/balena-iot-gate-imx8/environments/balena-staging.com%2Bsign-api-key - 204"}

Context

Are you using the hosted instance of probot/settings or running your own?

Self-hosted

If running your own instance, are you using it with github.com or GitHub Enterprise?

github.com

Version of probot/settings

We previously thought this issue had been addressed here: https://github.com/github/safe-settings/pull/691

Last reproduced in https://github.com/github/safe-settings/releases/tag/2.1.16

Version of GitHub Enterprise
Langage dominant
JavaScript
Étoiles
942
Forks
238
Métriques de merge des PR
Aucune PR mergée en 30 j

Préparer son environnement

Ouvrir dans Codespaces

Lance le conteneur de développement du projet dans votre navigateur, avec votre propre compte GitHub.

Par où commencer

  1. Lisez l'issue en entier, puis le guide de contribution du projet.
  2. Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
  3. Forkez le dépôt et travaillez sur une branche.
  4. Ouvrez une pull request qui référence le numéro de l'issue.

Autres issues de github-community-projects/safe-settings

Toutes les issues de github-community-projects/safe-settings

Issues similaires

Plus d'issues JavaScript

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.