Environment reviewers silently dropped when reviewer access is granted in the same sync
维护者通常 2 天内回复
还没有人认领这个 Issue。
评估
- 难度
- 4/5
- 预计耗时
- 3-5 天
- 新手友好度
- 55/100
- Issue 类型
- 缺陷
- 描述清晰度
- 描述清楚
- 活跃度
- 活跃
- 技术栈
- github, javascript
- 领域
- backend
调研方向
Start in lib/settings.js at the updateRepos() paths linked in the issue, then trace how the teams and environments child plugins are scheduled. Check how the environments plugin sends its PUT and what tests cover a full sync. Done means one sync that grants a team's repo access also creates the environment with that team as a reviewer.
由索引模型根据 Issue 内容生成。
描述
Problem Description
What is actually happening
A single config change that both grants a team repo access and names that team as an environment reviewer creates the environment without the reviewer. Example repo config:
teams:
- name: deployers
permission: maintain
environments:
- name: prod
reviewers:
- type: Team
id: 12345678 # deployers
updateRepos() runs every child plugin concurrently, so the environments plugin's PUT can land before the teams plugin grants access:
The no-repo-config branch has the same pattern:
GitHub's PUT /repos/{owner}/{repo}/environments/{environment_name} returns 200 for a reviewer that has no repo access, but it doesn't add the reviewer. The sync reports success, and the environment has no required reviewers until a later sync runs. Because nop mode doesn't render environment changes, the plan doesn't flag it either.
Debug log from the affected full sync, in order:
GitHub request: PUT https://api.github.com/repos/<org>/<repo>/environments/prod - 200
GitHub request: PUT https://api.github.com/orgs/<org>/teams/<team>/repos/<org>/<repo> - 204
What is the expected behavior
The environment is created with the configured reviewer in the same sync that grants the reviewer repo access.
Error output, if available
None. Every request returns 2xx.
Context
Are you using the hosted instance of probot/settings or running your own?
Running our own, via full-sync.js in GitHub Actions.
If running your own instance, are you using it with github.com or GitHub Enterprise?
github.com
Version of probot/settings
3.0.0, and the same code is on main-enterprise at e19444e0d69de050ba55d0262b71fcd8a98edfef
Version of GitHub Enterprise
- 主要语言
- JavaScript
- 星标
- 942
- 派生
- 238
- PR 合并指标
- 30 天内没有已合并 PR
环境准备
在浏览器里用你自己的 GitHub 账号启动这个项目的开发容器。
- 提供 Dockerfile 或 Docker Compose 文件
- 没有 Pull Request 模板
- 阅读贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
github-community-projects/safe-settings 的其他 Issue
-
Teams: teams with organization-role access show up as deletions可能已有人在做 @TovaBecker 于 1 天前认领。 未关闭
难度 2/5 1-3 小时 新手友好度 83/100
github-community-projects/safe-settings#1144 ·
维护者通常 2 天内回复
-
难度 2/5 1-3 小时 新手友好度 78/100
github-community-projects/safe-settings#1143 ·
维护者通常 2 天内回复
-
难度 2/5 1-3 小时 新手友好度 78/100
github-community-projects/safe-settings#1135 ·
维护者通常 2 天内回复
-
难度 2/5 1-3 小时 新手友好度 76/100
github-community-projects/safe-settings#1134 ·
维护者通常 2 天内回复
-
environments: additive_plugins is ignored, undeclared environments are deleted可能已有人在做 @yaunj 于 12 天前认领。 未关闭
难度 2/5 1-3 小时 新手友好度 78/100
github-community-projects/safe-settings#1133 ·
维护者通常 2 天内回复
查看 github-community-projects/safe-settings 的全部 Issue
相似的 Issue
-
难度 2/5 1-3 小时 新手友好度 72/100
cytoscape/cytoscape.js#3597 ·
维护者通常 5 天内回复
-
priority: low server testing
难度 1/5 1 小时以内 新手友好度 88/100
blamechris/chroxy#9277 ·
维护者通常 1 天内回复
-
难度 1/5 1 小时以内 新手友好度 72/100
sunososobro-hub/cloudball#191 ·
维护者通常 1 天内回复
-
[MCP]: page snapshots in .playwright-mcp/ are not git-ignored (.playwright-cli/ is, since #42318)未关闭
难度 2/5 1-3 小时 新手友好度 62/100
microsoft/playwright#44289 ·
维护者通常 1 天内回复
-
area:post effort:low enhancement P7 source:agent
难度 2/5 1-3 小时 新手友好度 68/100
维护者通常 1 天内回复