Environment reviewers silently dropped when reviewer access is granted in the same sync

Abierto
#1,128 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 2 días

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
4/5
Tiempo estimado
3-5 días
Aptitud para principiantes
55/100
Tipo de issue
Error
Claridad
Bien especificado
Estado de actividad
Activo
Stack tecnológico
github, javascript
Área
backend

Línea de trabajo

Start in lib/settings.js at the updateRepos() paths linked in the issue, then trace how the teams and environments child plugins are scheduled. Check how the environments plugin sends its PUT and what tests cover a full sync. Done means one sync that grants a team's repo access also creates the environment with that team as a reviewer.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

Problem Description

What is actually happening

A single config change that both grants a team repo access and names that team as an environment reviewer creates the environment without the reviewer. Example repo config:

teams:
  - name: deployers
    permission: maintain

environments:
  - name: prod
    reviewers:
      - type: Team
        id: 12345678 # deployers

updateRepos() runs every child plugin concurrently, so the environments plugin's PUT can land before the teams plugin grants access:

https://github.com/github-community-projects/safe-settings/blob/e19444e0d69de050ba55d0262b71fcd8a98edfef/lib/settings.js#L2150-L2152

The no-repo-config branch has the same pattern:

https://github.com/github-community-projects/safe-settings/blob/e19444e0d69de050ba55d0262b71fcd8a98edfef/lib/settings.js#L2196-L2201

GitHub's PUT /repos/{owner}/{repo}/environments/{environment_name} returns 200 for a reviewer that has no repo access, but it doesn't add the reviewer. The sync reports success, and the environment has no required reviewers until a later sync runs. Because nop mode doesn't render environment changes, the plan doesn't flag it either.

Debug log from the affected full sync, in order:

GitHub request: PUT https://api.github.com/repos/<org>/<repo>/environments/prod - 200
GitHub request: PUT https://api.github.com/orgs/<org>/teams/<team>/repos/<org>/<repo> - 204
What is the expected behavior

The environment is created with the configured reviewer in the same sync that grants the reviewer repo access.

Error output, if available

None. Every request returns 2xx.


Context

Are you using the hosted instance of probot/settings or running your own?

Running our own, via full-sync.js in GitHub Actions.

If running your own instance, are you using it with github.com or GitHub Enterprise?

github.com

Version of probot/settings

3.0.0, and the same code is on main-enterprise at e19444e0d69de050ba55d0262b71fcd8a98edfef

Version of GitHub Enterprise
Lenguaje dominante
JavaScript
Estrellas
942
Forks
238
Métricas de merge de PR
Sin PR fusionados en 30 d

Preparar el entorno

Abrir en Codespaces

Inicia el contenedor de desarrollo del proyecto en tu navegador, con tu propia cuenta de GitHub.

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de github-community-projects/safe-settings

Todos los issues de github-community-projects/safe-settings

Issues similares

Más issues de JavaScript

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.