RealIp does not account for clients on intranet
维护者通常 2 天内回复
@sl0thentr0py 已经在做这个了。
开始于 2025年4月9日。
评估
这个 Issue 还没有评估数据。
描述
Issue Description
sentry-ruby/lib/sentry/utils/real_ip.rb - Sentry::Utils::RealIp.initialize prepends a list of standard local and private IP blocks (LOCAL_ADDRESSES) to the supplied trusted_proxies.
The combined list is later used to determine the client's real IP by eliminating trusted proxies.
When hosting on a cloud provider and accessing from a client behind a firewall, this is fine - "user" will be the client's firewall LAN IP.
However, if hosting on the same LAN as the client, the client's IP will be filtered out. It's possible all candidate IPs will be filtered out in some situations.
Reproduction Steps
Set up a Rails app server, a reverse proxy, and a client all on the same LAN using one of the standard private CIDR blocks.
Configure the Rails app with sentry-rails and set and set config.action_dispatch.trusted_proxies to include only the IP of the reverse proxy.
Expected Behavior
The same behavior as Rails 7.1: If config.action_dispatch.trusted_proxies is set, the default list is replaced.
This allows the app to be more selective in which IPs it discards when choosing what IP to report as the client's.
(Note: config.action_dispatch.trusted_proxies now only accepts enumerable and always replaces the hard coded default.)
Actual Behavior
Sentry::Utils::RealIp.initialize will be called with the list of trusted_proxies from the ActionDispatch configuration, but these will be supplemented by the static LOCAL_ADDRESSES.
Since all LAN IPs will be matched by that list, Sentry will not see the client's real IP.
Ruby Version
3.1.6
SDK Version
5.19
Integration and Its Version
Rails
Sentry Config
The only relevant setting: send_default_pii = true
- 主要语言
- Ruby
- 星标
- 990
- 派生
- 552
- 平均合并
- 2 天 16 小时
- 30 天内合并 PR
- 29
环境准备
在浏览器里用你自己的 GitHub 账号启动这个项目的开发容器。
- 没有 Dockerfile 或 Docker Compose 文件
- 有 Pull Request 模板
- 阅读贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
getsentry/sentry-ruby 的其他 Issue
-
Bug Ruby
难度 2/5 1-3 小时 新手友好度 76/100
getsentry/sentry-ruby#3211 · 1 条评论 ·
维护者通常 2 天内回复
-
Events dropped client-side for size are only logged at debug level and not recorded as lost可能已有人在做 @sentry-junior 今天认领。 未关闭Bug Junior: repro Ruby
难度 2/5 1-3 小时 新手友好度 76/100
getsentry/sentry-ruby#3209 · 2 条评论 · 1 个 reaction ·
维护者通常 2 天内回复
-
with_child_span drops spans when blocks exit via break, return, or throw可能已有人在做 @itsrayeedscodespace 于 1 天前认领。 未关闭Bug Ruby Traces Waiting for: Product Owner
难度 2/5 1-3 小时 新手友好度 38/100
getsentry/sentry-ruby#3206 · 1 条评论 ·
维护者通常 2 天内回复
-
Let apps choose how the client IP on events is determined可能已有人在做 @sl0thentr0py 于 11 天前认领。 未关闭Improvement Ruby
getsentry/sentry-ruby#3180 · 2 条评论 · 1 个 reaction · 已指派 1 人 ·
维护者通常 2 天内回复
-
breaking change Next Major
难度 2/5 1-3 小时 新手友好度 58/100
getsentry/sentry-ruby#3176 · 1 条评论 ·
维护者通常 2 天内回复
查看 getsentry/sentry-ruby 的全部 Issue
相似的 Issue
-
enhancement
难度 2/5 1-3 小时 新手友好度 66/100
internetee/registry#2984 ·
维护者通常 6 天内回复
-
难度 2/5 1-3 小时 新手友好度 82/100
ecosyste-ms/issues#862 ·
维护者通常 1 天内回复
-
Redis Lua error `@user_script:52: ERR value is not an integer or out of range` when `window_size` is configured可能已有人在做 @mimosa 今天认领。 未关闭bug
难度 2/5 1-3 小时 新手友好度 82/100
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 67/100
riscv/riscv-unified-db#2829 ·
维护者通常 1 天内回复
-
⛓️ Security Difficulty: Easy Good First Issue Help Wanted ruby Type: Bug
难度 2/5 1-3 小时 新手友好度 82/100
rubyforgood/casa#7404 ·
维护者通常 1 天内回复