Clean up profile and replay artifacts on pre-envelope drops
还没有人认领这个 Issue。
评估
- 难度
- 4/5
- 预计耗时
- 3-5 天
- 新手友好度
- 45/100
- Issue 类型
- 缺陷
- 描述清晰度
- 描述清楚
- 活跃度
- 活跃
调研方向
The issue is in SentryClient's capture flow, specifically around envelope construction and sidecar file cleanup. Look at SentryClient, SentryEnvelopeItem.fromProfilingTrace, and SentryEnvelopeItem.fromReplay. The tests to add will involve temporary files and mocking EventProcessor and beforeSend callbacks. 'Done' means profile trace files and replay videos/folders are deleted on early drops, and discard reasons are correctly accounted for.
由索引模型根据 Issue 内容生成。
描述
Problem
SentryClient currently relies on lazy envelope-item serialization to clean up file-backed transaction profiles and replay recordings. If capture terminates after those sidecars exist but before envelope construction, serialization never takes ownership and the files are not promptly deleted.
This affects both EventProcessor and beforeSend* drop paths. PR #6142 adds new fail-closed exits when an EventProcessor throws, but the same ownership gap already exists for intentional processor drops and beforeSend* drops.
Affected paths
Profiled transactions
A profiled transaction can return before buildEnvelope(..., profilingTraceData) when:
- an EventProcessor returns
null; - an EventProcessor throws and the SDK fails closed;
beforeSendTransactionreturnsnull; orbeforeSendTransactionthrows.
The profile trace is normally deleted by the lazy serializer created in SentryEnvelopeItem.fromProfilingTrace. These early returns prevent that cleanup, allowing sensitive profile data and disk usage to accumulate in long-running Android apps or JVM services.
Session replays
A replay can return before replay envelope construction when:
- an EventProcessor returns
null; - an EventProcessor throws and the SDK fails closed;
beforeSendReplayreturnsnull; orbeforeSendReplaythrows.
Replay cleanup currently occurs in the serializer created by SentryEnvelopeItem.fromReplay. Bypassing it can retain the replay video or, for a backfilled replay, the entire replay folder.
Expected behavior
Introduce explicit ownership for file-backed sidecars so every terminal pre-envelope drop either:
- transfers the sidecar to an envelope item that owns serialization and cleanup; or
- disposes of the sidecar immediately at the capture boundary.
The implementation should:
- delete abandoned profile trace files;
- delete normal replay videos and the correct backfilled replay folder;
- record one dropped profile with the same discard reason as its transaction (
event_processor,before_send, orcallback_error); - avoid double deletion and double accounting; and
- preserve existing replay-folder semantics and transaction/span discard quantities.
Tests
Add real temporary-file regression coverage for:
- profiled transactions dropped by processor null and processor exception;
- profiled transactions dropped by
beforeSendTransactionnull and exception; - normal replay videos dropped by processor and
beforeSendReplaypaths; - backfilled replay folders dropped by processor and
beforeSendReplaypaths; and DataCategory.Profileaccounting under each corresponding discard reason.
Context
This was identified while reviewing #6142. The fail-closed processor behavior is correct; the issue is that cleanup is coupled to envelope serialization even though several valid terminal paths return before an envelope is built.
- 主要语言
- Kotlin
- 星标
- 1.4k
- 派生
- 478
- 平均合并
- 2 天 20 小时
- 30 天内合并 PR
- 71
贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
getsentry/sentry-java 的其他 Issue
-
Improvement Java Platform: Android Platform: Java
难度 2/5 1-3 小时 新手友好度 75/100
getsentry/sentry-java#6145 · 1 条评论 · 已指派 1 人 ·
-
Bug Java Platform: Android Platform: Java
难度 2/5 1-3 小时 新手友好度 78/100
getsentry/sentry-java#6138 · 1 条评论 ·
-
Feature Java Platform: Java Spans
难度 2/5 1-3 小时 新手友好度 68/100
getsentry/sentry-java#5984 · 1 条评论 ·
-
Android Task Traces
难度 2/5 1-3 小时 新手友好度 68/100
getsentry/sentry-java#5376 · 1 条评论 ·
-
Android Docs Errors
难度 2/5 1-3 小时 新手友好度 64/100
getsentry/sentry-java#5375 · 1 条评论 ·
查看 getsentry/sentry-java 的全部 Issue
相似的 Issue
-
enhancement
难度 2/5 1-3 小时 新手友好度 75/100
Richie97/track-history#325 ·
-
bug CLI documentation reliability
难度 2/5 1-3 小时 新手友好度 70/100
-
KW-related Type:bug UI / UX
难度 2/5 1-3 小时 新手友好度 70/100
-
bug
难度 2/5 1-3 小时 新手友好度 75/100
RevenueCat/purchases-android#4299 · 1 条评论 ·
-
bug
难度 2/5 1-3 小时 新手友好度 75/100
AAswordman/Operit#1265 · 3 条评论 ·