Clean up profile and replay artifacts on pre-envelope drops
Nadie ha tomado este issue todavía.
Evaluación
- Dificultad
- 4/5
- Tiempo estimado
- 3-5 días
- Aptitud para principiantes
- 45/100
- Tipo de issue
- Error
- Claridad
- Bien especificado
- Estado de actividad
- Activo
- Área
- backend-api-design, devtools
Línea de trabajo
The issue is in SentryClient's capture flow, specifically around envelope construction and sidecar file cleanup. Look at SentryClient, SentryEnvelopeItem.fromProfilingTrace, and SentryEnvelopeItem.fromReplay. The tests to add will involve temporary files and mocking EventProcessor and beforeSend callbacks. 'Done' means profile trace files and replay videos/folders are deleted on early drops, and discard reasons are correctly accounted for.
Escrito por el modelo de indexación a partir del texto del issue.
Descripción
Problem
SentryClient currently relies on lazy envelope-item serialization to clean up file-backed transaction profiles and replay recordings. If capture terminates after those sidecars exist but before envelope construction, serialization never takes ownership and the files are not promptly deleted.
This affects both EventProcessor and beforeSend* drop paths. PR #6142 adds new fail-closed exits when an EventProcessor throws, but the same ownership gap already exists for intentional processor drops and beforeSend* drops.
Affected paths
Profiled transactions
A profiled transaction can return before buildEnvelope(..., profilingTraceData) when:
- an EventProcessor returns
null; - an EventProcessor throws and the SDK fails closed;
beforeSendTransactionreturnsnull; orbeforeSendTransactionthrows.
The profile trace is normally deleted by the lazy serializer created in SentryEnvelopeItem.fromProfilingTrace. These early returns prevent that cleanup, allowing sensitive profile data and disk usage to accumulate in long-running Android apps or JVM services.
Session replays
A replay can return before replay envelope construction when:
- an EventProcessor returns
null; - an EventProcessor throws and the SDK fails closed;
beforeSendReplayreturnsnull; orbeforeSendReplaythrows.
Replay cleanup currently occurs in the serializer created by SentryEnvelopeItem.fromReplay. Bypassing it can retain the replay video or, for a backfilled replay, the entire replay folder.
Expected behavior
Introduce explicit ownership for file-backed sidecars so every terminal pre-envelope drop either:
- transfers the sidecar to an envelope item that owns serialization and cleanup; or
- disposes of the sidecar immediately at the capture boundary.
The implementation should:
- delete abandoned profile trace files;
- delete normal replay videos and the correct backfilled replay folder;
- record one dropped profile with the same discard reason as its transaction (
event_processor,before_send, orcallback_error); - avoid double deletion and double accounting; and
- preserve existing replay-folder semantics and transaction/span discard quantities.
Tests
Add real temporary-file regression coverage for:
- profiled transactions dropped by processor null and processor exception;
- profiled transactions dropped by
beforeSendTransactionnull and exception; - normal replay videos dropped by processor and
beforeSendReplaypaths; - backfilled replay folders dropped by processor and
beforeSendReplaypaths; and DataCategory.Profileaccounting under each corresponding discard reason.
Context
This was identified while reviewing #6142. The fail-closed processor behavior is correct; the issue is that cleanup is coupled to envelope serialization even though several valid terminal paths return before an envelope is built.
- Lenguaje dominante
- Kotlin
- Estrellas
- 1.4k
- Forks
- 478
- Merge medio
- 2 d 20 h
- PR fusionados (30 d)
- 71
Guía de contribución
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Más de getsentry/sentry-java
-
Improvement Java Platform: Android Platform: Java
Dificultad 2/5 1-3 horas Aptitud para principiantes 75/100
getsentry/sentry-java#6145 · 1 comentario · 1 asignado ·
-
Bug Java Platform: Android Platform: Java
Dificultad 2/5 1-3 horas Aptitud para principiantes 78/100
getsentry/sentry-java#6138 · 1 comentario ·
-
Feature Java Platform: Java Spans
Dificultad 2/5 1-3 horas Aptitud para principiantes 68/100
getsentry/sentry-java#5984 · 1 comentario ·
-
Android Task Traces
Dificultad 2/5 1-3 horas Aptitud para principiantes 68/100
getsentry/sentry-java#5376 · 1 comentario ·
-
Android Docs Errors
Dificultad 2/5 1-3 horas Aptitud para principiantes 64/100
getsentry/sentry-java#5375 · 1 comentario ·
Todos los issues de getsentry/sentry-java
Issues similares
-
[Bug] 统计页面无法重置token和汇率 Abiertobug
Dificultad 2/5 1-3 horas Aptitud para principiantes 75/100
AAswordman/Operit#1265 · 3 comentarios ·
-
The extension stopped working. AbiertoSource is down
Dificultad 2/5 1-3 horas Aptitud para principiantes 70/100
keiyoushi/extensions-source#19317 ·
-
Tambahkan bahasa Indonesia Abierto
Dificultad 2/5 1-3 horas Aptitud para principiantes 65/100
acristescu/OnlineGo#216 ·
-
Remove custom segment colors Abiertoenhancement
Dificultad 2/5 1-3 horas Aptitud para principiantes 65/100
libre-tube/LibreTube#8803 ·
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 75/100