Bug: Toggling stacked or tabbed layout off changes the container's split direction

未关闭
#563 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

@mattchristenson 已经在做这个了。

开始于 2026年9月30日。

  • #567 来自 @mattchristenson —— 未关闭

评估

难度
3/5
预计耗时
1-2 天
新手友好度
30/100
Issue 类型
缺陷
描述清晰度
基本清楚
活跃度
停滞
技术栈
javascript
领域
desktop

调研方向

The issue names determineSplitLayout() as the function that picks split direction from the monitor shape. Locate it in the extension's JavaScript source and read how callers exit tabbed/stacked groups. The external reproduction script exercises the toggles; done means the original split direction is restored per the acceptance criteria.

由索引模型根据 Issue 内容生成。

描述

Problem. Take a container whose windows sit one above the other (vertical split). Press Super+Shift+S (stacked) and then Super+Shift+S again. The windows come back side by side instead of one above the other. The same happens with Super+Shift+T (tabbed), when a tab group auto-exits because only one window is left, and when the stacked or tabbed feature is turned off in the settings.

after toggling stacked twice: main vs fix

Cause. Every way back from a group to a split uses determineSplitLayout(). That picks a direction from the monitor's shape (side by side on a landscape monitor), not from the container. The direction the container had before is not kept anywhere.

Desired outcome. Leaving a tabbed or stacked group restores the split direction the container had before it became a group. The monitor's shape is used only for a group that never was a split, such as one created by drag and drop.

Acceptance criteria.

  • A vertical split toggled to stacked and back is a vertical split again; the same for a horizontal split, and for tabbed.
  • Switching stacked → tabbed → split (or tabbed → stacked → split) restores the original direction.
  • Auto-exit of a tab group, and turning off the stacked or tabbed feature, restore the original direction.
  • A group created directly (drag and drop to the centre) still gets the monitor's direction when it leaves the group.

Reproduction: scenarios/17_stack_tab_switching.py (17.1, 17.2).

主要语言
JavaScript
星标
1.3k
派生
112
PR 合并指标
30 天内没有已合并 PR

环境准备

这个项目没有提供开发容器、Dockerfile 或贡献指南,环境需要你自己搭建:先看它的 README,通用步骤见我们的新手贡献指南。

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

forge-ext/forge 的其他 Issue

查看 forge-ext/forge 的全部 Issue

相似的 Issue

更多 JavaScript Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。