Bug: Toggling stacked or tabbed layout off changes the container's split direction

Abierto
  • ¿Algo no está bien?
#563 0 comentarios 0 reacciones 0 asignados Ver en GitHub

@mattchristenson ya está trabajando en esto.

Desde el 30/9/2026.

  • #567 de @mattchristenson — abierto

Evaluación

Dificultad
3/5
Tiempo estimado
1-2 días
Aptitud para principiantes
30/100
Tipo de issue
Error
Claridad
Bastante claro
Estado de actividad
Estancado
Stack tecnológico
javascript
Área
desktop

Línea de trabajo

The issue names determineSplitLayout() as the function that picks split direction from the monitor shape. Locate it in the extension's JavaScript source and read how callers exit tabbed/stacked groups. The external reproduction script exercises the toggles; done means the original split direction is restored per the acceptance criteria.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

Problem. Take a container whose windows sit one above the other (vertical split). Press Super+Shift+S (stacked) and then Super+Shift+S again. The windows come back side by side instead of one above the other. The same happens with Super+Shift+T (tabbed), when a tab group auto-exits because only one window is left, and when the stacked or tabbed feature is turned off in the settings.

after toggling stacked twice: main vs fix

Cause. Every way back from a group to a split uses determineSplitLayout(). That picks a direction from the monitor's shape (side by side on a landscape monitor), not from the container. The direction the container had before is not kept anywhere.

Desired outcome. Leaving a tabbed or stacked group restores the split direction the container had before it became a group. The monitor's shape is used only for a group that never was a split, such as one created by drag and drop.

Acceptance criteria.

  • A vertical split toggled to stacked and back is a vertical split again; the same for a horizontal split, and for tabbed.
  • Switching stacked → tabbed → split (or tabbed → stacked → split) restores the original direction.
  • Auto-exit of a tab group, and turning off the stacked or tabbed feature, restore the original direction.
  • A group created directly (drag and drop to the centre) still gets the monitor's direction when it leaves the group.

Reproduction: scenarios/17_stack_tab_switching.py (17.1, 17.2).

Lenguaje dominante
JavaScript
Estrellas
1.3k
Forks
112
Sin PR fusionados en 30 d

Preparar el entorno

Este proyecto no incluye contenedor de desarrollo, Dockerfile ni guía de contribución, así que la configuración corre por tu cuenta: empieza por su README y consulta nuestra guía para la primera contribución para los pasos generales.

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de forge-ext/forge

Todos los issues de forge-ext/forge

Issues similares

Más issues de JavaScript

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.