Hacktoberfest 2026:维护者为十月标记出来的 issue,仍然开放、适合新手。 浏览 Hacktoberfest issue

[BUG][code-analyzer] sfge: passing a boolean expression (==, &&) directly to an Apex method aborts the entry point

未关闭
#2,103 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

还没有人认领这个 Issue。

评估

难度
3/5
预计耗时
1-2 天
新手友好度
63/100
Issue 类型
缺陷
描述清晰度
描述清楚
活跃度
活跃
技术栈
java, typescript

调研方向

Start with MethodTypeMatchUtil.java, especially parameterTypesMatch and getTypeFromSymbol, then inspect how BooleanExpressionVertex is represented and tested. Reproduce with the provided Apex class and sfge command; verify the entry point is analysed and the expected ApexFlsViolation on the insert is reported without an InternalExecutionError.

由索引模型根据 Issue 内容生成。

描述

Have you tried to resolve this issue yourself first?
  • I confirm I have gone through the above steps and still have an issue to report.
Bug Description

Engine: sfge (Salesforce Graph Engine) · Rule: ApexFlsViolation (DevPreview) · Selector: --rule-selector sfge

To pick the method a call resolves to, MethodTypeMatchUtil.parameterTypesMatch types each argument. It handles null literals, new collections, variables, SOQL, invocables, BinaryExpressionVertex and Typeable, and sends anything else to getTypeFromSymbol. That method throws when the argument has no symbolic name:

// MethodTypeMatchUtil.java:165-168
String symbolicName = invokedParameter.getSymbolicName().orElse(null);
if (symbolicName == null) {
    throw new UnexpectedException(invokedParameter);
}

A BooleanExpressionVertex (a == b, a != b, a && b, a || b) is neither a BinaryExpressionVertex nor Typeable and has no symbolic name, so any call that passes one straight to a method declared on an Apex class aborts the entry point.

b.put('isDefault', name == 'Default');

Standard-library methods are not affected, since sfge models them on the value and never runs the type match: Map<String, Object>.put('k', a != null && a == 'x') is analysed normally.

Output / Logs
UnexpectedException: BooleanExpression{properties={FirstChild=false, Operator===, BeginLine=10, DefiningType=BooleanArgToUserMethod, EndLine=10, childIdx=2, BeginColumn=28}}:
com.salesforce.graph.ops.MethodTypeMatchUtil.getTypeFromSymbol(MethodTypeMatchUtil.java:167);
com.salesforce.graph.ops.MethodTypeMatchUtil.parameterTypesMatch(MethodTypeMatchUtil.java:150);
com.salesforce.graph.ops.MethodUtil.getInvoked(MethodUtil.java:358);
com.salesforce.graph.ops.MethodUtil.getInvoked(MethodUtil.java:158);
com.salesforce.graph.ops.MethodUtil.getPaths(MethodUtil.java:626);
com.salesforce.graph.ops.expander.ApexPathExpander.resolveMethodCall(ApexPathExpander.java:849)
Steps To Reproduce
  1. Create an empty SFDX project (sfdx-project.json with a single force-app package directory).
  2. Add force-app/main/default/classes/BooleanArgToUserMethod.cls with the class shown below, plus a standard BooleanArgToUserMethod.cls-meta.xml (apiVersion 62.0).
  3. Add code-analyzer.yml:
    engines:
      sfge:
        java_thread_timeout: 900000
        java_thread_count: 4
    
  4. Run:
    sf code-analyzer run --rule-selector sfge --workspace . --config-file code-analyzer.yml
    
  5. The run reports an InternalExecutionError for the entry point instead of analysing it. The insert goes unreported: the entry point yields no ApexFlsViolation at all, and nothing in the summary indicates coverage was lost.
public with sharing class BooleanArgToUserMethod {
    public class Bag {
        public void put(String key, Object value) {
        }
    }

    @AuraEnabled
    public static void run(String name) {
        Bag b = new Bag();
        b.put('isDefault', name == 'Default');
        insert new Account(Name = name);
    }
}
Expected Behavior

A boolean expression is a Boolean, and it should match a Boolean or Object parameter. Suggested fix: type BooleanExpressionVertex as Boolean in parameterTypesMatch, next to the BinaryExpressionVertex branch, or make it Typeable.

More generally, an argument the matcher cannot type should count as an unknown match rather than abort the entry point.

Operating System

macOS 26.7.1

Salesforce CLI Version

@salesforce/cli/2.147.7 darwin-arm64 node-v24.5.0

Code Analyzer Plugin (code-analyzer) Version

code-analyzer 5.15.0

Node Version

v24.5.0

Java Version

openjdk version "11.0.32" 2026-07-21

Python Version

N/A

Additional Context (Screenshots, Files, etc)

Also fails on code-analyzer 5.16.0 (sfge 0.25.0) under OpenJDK 21 on ubuntu-latest, with the same stack. In our codebase it abandons 3 @AuraEnabled entry points, all of them building a response with put(key, <comparison>).

A control in the same workspace, with the argument assigned to a local first (Boolean isDefault = name == 'Default'; b.put('isDefault', isDefault);), was analysed normally and reports the expected ApexFlsViolation on the insert.

The identical stack was reported in #1497 ("We received 6 of these, all with identical error and stack"), the consolidation issue closed in the 2026-06-30 pre-v5 sweep. That comment got no reply, and the bug has no issue of its own.

Workaround

Assign the expression to a local Boolean and pass the variable.

Urgency

Moderate

主要语言
TypeScript
星标
241
派生
51
PR 合并指标
30 天内没有已合并 PR

环境准备

  • 没有 Dockerfile 或 Docker Compose 文件
  • 没有 Pull Request 模板
  • 阅读贡献指南

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

forcedotcom/code-analyzer 的其他 Issue

查看 forcedotcom/code-analyzer 的全部 Issue

相似的 Issue

更多 TypeScript Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。