Hacktoberfest 2026: los issues que los mantenedores marcaron para octubre, abiertos y aptos para principiantes. Explorar issues de Hacktoberfest

[BUG][code-analyzer] sfge: passing a boolean expression (==, &&) directly to an Apex method aborts the entry point

Abierto
  • ¿Algo no está bien?
#2,103 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
3/5
Tiempo estimado
1-2 días
Aptitud para principiantes
63/100
Tipo de issue
Error
Claridad
Bien especificado
Estado de actividad
Activo
Stack tecnológico
java, typescript
Área
backend, testing-qa

Línea de trabajo

Start with MethodTypeMatchUtil.java, especially parameterTypesMatch and getTypeFromSymbol, then inspect how BooleanExpressionVertex is represented and tested. Reproduce with the provided Apex class and sfge command; verify the entry point is analysed and the expected ApexFlsViolation on the insert is reported without an InternalExecutionError.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

Have you tried to resolve this issue yourself first?
  • I confirm I have gone through the above steps and still have an issue to report.
Bug Description

Engine: sfge (Salesforce Graph Engine) · Rule: ApexFlsViolation (DevPreview) · Selector: --rule-selector sfge

To pick the method a call resolves to, MethodTypeMatchUtil.parameterTypesMatch types each argument. It handles null literals, new collections, variables, SOQL, invocables, BinaryExpressionVertex and Typeable, and sends anything else to getTypeFromSymbol. That method throws when the argument has no symbolic name:

// MethodTypeMatchUtil.java:165-168
String symbolicName = invokedParameter.getSymbolicName().orElse(null);
if (symbolicName == null) {
    throw new UnexpectedException(invokedParameter);
}

A BooleanExpressionVertex (a == b, a != b, a && b, a || b) is neither a BinaryExpressionVertex nor Typeable and has no symbolic name, so any call that passes one straight to a method declared on an Apex class aborts the entry point.

b.put('isDefault', name == 'Default');

Standard-library methods are not affected, since sfge models them on the value and never runs the type match: Map<String, Object>.put('k', a != null && a == 'x') is analysed normally.

Output / Logs
UnexpectedException: BooleanExpression{properties={FirstChild=false, Operator===, BeginLine=10, DefiningType=BooleanArgToUserMethod, EndLine=10, childIdx=2, BeginColumn=28}}:
com.salesforce.graph.ops.MethodTypeMatchUtil.getTypeFromSymbol(MethodTypeMatchUtil.java:167);
com.salesforce.graph.ops.MethodTypeMatchUtil.parameterTypesMatch(MethodTypeMatchUtil.java:150);
com.salesforce.graph.ops.MethodUtil.getInvoked(MethodUtil.java:358);
com.salesforce.graph.ops.MethodUtil.getInvoked(MethodUtil.java:158);
com.salesforce.graph.ops.MethodUtil.getPaths(MethodUtil.java:626);
com.salesforce.graph.ops.expander.ApexPathExpander.resolveMethodCall(ApexPathExpander.java:849)
Steps To Reproduce
  1. Create an empty SFDX project (sfdx-project.json with a single force-app package directory).
  2. Add force-app/main/default/classes/BooleanArgToUserMethod.cls with the class shown below, plus a standard BooleanArgToUserMethod.cls-meta.xml (apiVersion 62.0).
  3. Add code-analyzer.yml: 
    engines:
  sfge:
    java_thread_timeout: 900000
    java_thread_count: 4
  4. Run: 
    sf code-analyzer run --rule-selector sfge --workspace . --config-file code-analyzer.yml
  5. The run reports an InternalExecutionError for the entry point instead of analysing it. The insert goes unreported: the entry point yields no ApexFlsViolation at all, and nothing in the summary indicates coverage was lost.
public with sharing class BooleanArgToUserMethod {
    public class Bag {
        public void put(String key, Object value) {
        }
    }

    @AuraEnabled
    public static void run(String name) {
        Bag b = new Bag();
        b.put('isDefault', name == 'Default');
        insert new Account(Name = name);
    }
}
Expected Behavior

A boolean expression is a Boolean, and it should match a Boolean or Object parameter. Suggested fix: type BooleanExpressionVertex as Boolean in parameterTypesMatch, next to the BinaryExpressionVertex branch, or make it Typeable.

More generally, an argument the matcher cannot type should count as an unknown match rather than abort the entry point.

Operating System

macOS 26.7.1

Salesforce CLI Version

@salesforce/cli/2.147.7 darwin-arm64 node-v24.5.0

Code Analyzer Plugin (code-analyzer) Version

code-analyzer 5.15.0

Node Version

v24.5.0

Java Version

openjdk version "11.0.32" 2026-07-21

Python Version

N/A

Additional Context (Screenshots, Files, etc)

Also fails on code-analyzer 5.16.0 (sfge 0.25.0) under OpenJDK 21 on ubuntu-latest, with the same stack. In our codebase it abandons 3 @AuraEnabled entry points, all of them building a response with put(key, <comparison>).

A control in the same workspace, with the argument assigned to a local first (Boolean isDefault = name == 'Default'; b.put('isDefault', isDefault);), was analysed normally and reports the expected ApexFlsViolation on the insert.

The identical stack was reported in #1497 ("We received 6 of these, all with identical error and stack"), the consolidation issue closed in the 2026-06-30 pre-v5 sweep. That comment got no reply, and the bug has no issue of its own.

Workaround

Assign the expression to a local Boolean and pass the variable.

Urgency

Moderate

Lenguaje dominante
TypeScript
Estrellas
241
Forks
51
Sin PR fusionados en 30 d

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de forcedotcom/code-analyzer

Todos los issues de forcedotcom/code-analyzer

Issues similares

Más issues de TypeScript

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.