project deploy start exits 10 "fetch failed" when the connection closes between status checks; the deploy keeps running

未关闭
  • 哪里不对？
#3,685 2 条评论 1 个 reaction 已指派 0 人 在 GitHub 查看

还没有人认领这个 Issue。

评估

难度
4/5
预计耗时
3-5 天
新手友好度
53/100
Issue 类型
缺陷
描述清晰度
描述清楚
活跃度
活跃
技术栈
javascript, node.js
领域
cli, networking

调研方向

Start by reading source-deploy-retrieve's MetadataTransfer.isRetryableError and pollStatus path, then check the reported jsforce and undici error shapes. Reproduce the dropped connection with the CONNECT proxy described in the issue. Done when the deploy keeps polling after this transient failure and returns its final result; add coverage for the retryable error if the repository has relevant tests.

由索引模型根据 Issue 内容生成。

描述

bug
Before You Submit
  • I'm using the latest version of Salesforce CLI (reproduced on 2.157.8)
  • I've searched the existing issues (related: #3622, which is about HTTP/2 crashes in data commands; this one is HTTP/1.1 and handled, but not retried)
Command

sf project deploy start (also deploy validate, deploy quick: any command that waits with MetadataApiDeploy.pollStatus)

Org Type

Sandbox

Did this work before?

Not sure

Summary

When Salesforce closes the HTTP connection between two deploy status checks, sf project deploy start --wait N exits 10 with MetadataTransferError: Metadata API request failed: fetch failed, while the deploy keeps running and later succeeds in the org. In CI this marks a successful deploy as failed.

Cause, as far as we can read the code:

  • jsforce-node's fetchWithRetries retries only GET/PUT/HEAD/OPTIONS/DELETE; checkDeployStatus is a SOAP POST, so the request is not retried.
  • source-deploy-retrieve MetadataTransfer.isRetryableError tolerates network errors by matching error.message against ECONNRESET, socket hang up, etc. With undici the message is fetch failed (the cause, SocketError: other side closed, UND_ERR_SOCKET, is in error.cause), so none match and poll() rethrows. Same list in SDR 13.6.0 and 13.12.0.

We saw it 4 times in 20 minutes, from two different machines (GitHub Actions runners and a cloud VM), against the same sandbox, with no Trust incident.

Steps to reproduce

The closure is intermittent; we reproduce it deterministically with a local CONNECT proxy that closes the tunnel of one status check:

  1. Run a CONNECT proxy on 127.0.0.1:18081 that, after ~20 s, closes the next tunnel right after the client sends its request (about 20 lines of Node net; happy to share).
  2. HTTPS_PROXY=http://127.0.0.1:18081 sf project deploy start --dry-run --source-dir force-app/main/default/classes -o <sandbox> --test-level RunSpecifiedTests --tests SomeTest --wait 10 --json
Expected Result

The CLI treats the closed connection as a transient network error (as it does for ECONNRESET), keeps polling, and returns the deploy's final result (exit 0 here).

Actual Result

Exit 10 after the first closed connection:

{"status":10,"name":"MetadataTransferError","message":"Metadata API request failed: fetch failed","data":{"id":"0Af..."}}

The CLI log (~/.sf/sf-YYYY-MM-DD.log) has:

TypeError: fetch failed
    at Object.processResponse (undici/lib/web/fetch/index.js:272:16)
    at async fetchWithRetries (@jsforce/jsforce-node/lib/request.js:111:25)
caused by: SocketError: other side closed
    at TLSSocket.onHttpSocketEnd (undici/lib/dispatcher/client-h1.js:1024:22)

sf project deploy report --job-id <id> afterwards shows the job Succeeded.

Suggested fix

In isRetryableError, also inspect error.cause (and error.cause.cause) for code in UND_ERR_SOCKET, ECONNRESET, ETIMEDOUT, …, or add fetch failed / other side closed to retryableErrors. A status check is read-only, so retrying it is safe.

Our workaround: when the command exits 10 with this error and data.id, we follow the same job with sf project deploy report --job-id <id> --wait <remaining>.

System Information
@salesforce/cli/2.157.8 linux-x64 node-v24.22.2
@salesforce/source-deploy-retrieve 13.11.0, @jsforce/jsforce-node 3.12.0, undici 8.12.3
(also @salesforce/cli 2.156.5: SDR 13.6.0, undici 8.12.2)
主要语言
没有语言数据
星标
575
派生
80
平均合并
5 小时 58 分钟
30 天内合并 PR
4

环境准备

  • 没有 Dockerfile 或 Docker Compose 文件
  • 没有 Pull Request 模板
  • 阅读贡献指南

从这里开始

  1. 先读完整个 Issue，再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库，在一个分支上完成修改。
  4. 提交 Pull Request，并在描述里引用这个 Issue 编号。

forcedotcom/cli 的其他 Issue

查看 forcedotcom/cli 的全部 Issue

相似的 Issue

更多 CLI Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。