project deploy start exits 10 "fetch failed" when the connection closes between status checks; the deploy keeps running

オープン
  • 何か問題がありますか？
#3,685 コメント 2 件 リアクション 1 件 担当者 0 名 GitHub で見る

まだ誰も着手していません。

評価

難易度
4/5
見積もり時間
3〜5日
初心者へのやさしさ
53/100
issue の種類
バグ
明瞭さ
明確に書かれている
活発さ
活発
技術スタック
javascript, node.js
領域
cli, networking

調査の方向性

Start by reading source-deploy-retrieve's MetadataTransfer.isRetryableError and pollStatus path, then check the reported jsforce and undici error shapes. Reproduce the dropped connection with the CONNECT proxy described in the issue. Done when the deploy keeps polling after this transient failure and returns its final result; add coverage for the retryable error if the repository has relevant tests.

索引モデルが issue の本文から書いたものです。

説明

bug
Before You Submit
  • I'm using the latest version of Salesforce CLI (reproduced on 2.157.8)
  • I've searched the existing issues (related: #3622, which is about HTTP/2 crashes in data commands; this one is HTTP/1.1 and handled, but not retried)
Command

sf project deploy start (also deploy validate, deploy quick: any command that waits with MetadataApiDeploy.pollStatus)

Org Type

Sandbox

Did this work before?

Not sure

Summary

When Salesforce closes the HTTP connection between two deploy status checks, sf project deploy start --wait N exits 10 with MetadataTransferError: Metadata API request failed: fetch failed, while the deploy keeps running and later succeeds in the org. In CI this marks a successful deploy as failed.

Cause, as far as we can read the code:

  • jsforce-node's fetchWithRetries retries only GET/PUT/HEAD/OPTIONS/DELETE; checkDeployStatus is a SOAP POST, so the request is not retried.
  • source-deploy-retrieve MetadataTransfer.isRetryableError tolerates network errors by matching error.message against ECONNRESET, socket hang up, etc. With undici the message is fetch failed (the cause, SocketError: other side closed, UND_ERR_SOCKET, is in error.cause), so none match and poll() rethrows. Same list in SDR 13.6.0 and 13.12.0.

We saw it 4 times in 20 minutes, from two different machines (GitHub Actions runners and a cloud VM), against the same sandbox, with no Trust incident.

Steps to reproduce

The closure is intermittent; we reproduce it deterministically with a local CONNECT proxy that closes the tunnel of one status check:

  1. Run a CONNECT proxy on 127.0.0.1:18081 that, after ~20 s, closes the next tunnel right after the client sends its request (about 20 lines of Node net; happy to share).
  2. HTTPS_PROXY=http://127.0.0.1:18081 sf project deploy start --dry-run --source-dir force-app/main/default/classes -o <sandbox> --test-level RunSpecifiedTests --tests SomeTest --wait 10 --json
Expected Result

The CLI treats the closed connection as a transient network error (as it does for ECONNRESET), keeps polling, and returns the deploy's final result (exit 0 here).

Actual Result

Exit 10 after the first closed connection:

{"status":10,"name":"MetadataTransferError","message":"Metadata API request failed: fetch failed","data":{"id":"0Af..."}}

The CLI log (~/.sf/sf-YYYY-MM-DD.log) has:

TypeError: fetch failed
    at Object.processResponse (undici/lib/web/fetch/index.js:272:16)
    at async fetchWithRetries (@jsforce/jsforce-node/lib/request.js:111:25)
caused by: SocketError: other side closed
    at TLSSocket.onHttpSocketEnd (undici/lib/dispatcher/client-h1.js:1024:22)

sf project deploy report --job-id <id> afterwards shows the job Succeeded.

Suggested fix

In isRetryableError, also inspect error.cause (and error.cause.cause) for code in UND_ERR_SOCKET, ECONNRESET, ETIMEDOUT, …, or add fetch failed / other side closed to retryableErrors. A status check is read-only, so retrying it is safe.

Our workaround: when the command exits 10 with this error and data.id, we follow the same job with sf project deploy report --job-id <id> --wait <remaining>.

System Information
@salesforce/cli/2.157.8 linux-x64 node-v24.22.2
@salesforce/source-deploy-retrieve 13.11.0, @jsforce/jsforce-node 3.12.0, undici 8.12.3
(also @salesforce/cli 2.156.5: SDR 13.6.0, undici 8.12.2)
主要言語
言語のデータがありません
スター
575
フォーク
80
平均マージ
5時間 58分
マージ済み PR（30日）
4

環境構築

はじめの一歩

  1. issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
  2. 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
  3. リポジトリをフォークし、ブランチを切って変更します。
  4. issue 番号を参照したプルリクエストを送ります。

forcedotcom/cli のほかの issue

forcedotcom/cli の issue をすべて見る

似ている issue

CLI の issue をもっと見る

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。