Webhook recovery test counts recurring jobs that the shared host fires after its clock moves

未关闭
#3,409 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

还没有人认领这个 Issue。

评估

难度
3/5
预计耗时
1-2 天
新手友好度
58/100
Issue 类型
缺陷
描述清晰度
基本清楚
活跃度
活跃
技术栈
csharp
领域
backend, testing

调研方向

Start with WebhookRecoveryTests.AQueueWhoseWakeUpWasLostIsSentInOrderByTheQueueJobAndKeptByRetention and WebhookFixture.HostAsync in the FluentCMS.Plugins.Webhooks.Tests project. Run the failing test alone, then with the full project, and trace how the host clock advance and recurring job runner affect RunDueJobsAsync. Done means the test passes in a full project run on main.

由索引模型根据 Issue 内容生成。

描述

area:testing plugin type:bug

Problem

WebhookRecoveryTests.AQueueWhoseWakeUpWasLostIsSentInOrderByTheQueueJobAndKeptByRetention fails when the whole FluentCMS.Plugins.Webhooks.Tests project runs. It fails on main as well (checked at 034616ae on Windows arm64, SQLite). It passes when run alone or with its class.

The test expects RunDueJobsAsync to run one job, the retention it enqueued, but it ran six. The other five were content.trash.purge, jobs.retention, idempotency.retention, activity.retention and webhooks.retention, all on the default queue. WebhookFixture.HostAsync moves the host's clock forward two days and pumps. The host's own job runner then fires the recurring jobs that became due, from its maintenance loop, after the pump has finished. They are still due when the test runs, so it counts them.

Proposal

Have HostAsync wait until the recurring jobs the clock move made due have fired and run, for example by firing them itself before it pumps. Or have the test count only the jobs it enqueued.

Acceptance

  • The test passes in a full run of the project, on main
主要语言
C#
星标
567
派生
107
平均合并
1 小时 19 分钟
30 天内合并 PR
353

环境准备

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

fluentcms/FluentCMS 的其他 Issue

查看 fluentcms/FluentCMS 的全部 Issue

相似的 Issue

更多 C# Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。