Webhook recovery test counts recurring jobs that the shared host fires after its clock moves

Aperta
#3,409 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
3/5
Tempo stimato
1-2 giorni
Idoneità per principianti
58/100
Tipo di issue
Bug
Chiarezza
Abbastanza chiara
Stato di attività
Attiva
Stack tecnologico
csharp
Ambito
backend, testing

Direzione di ricerca

Start with WebhookRecoveryTests.AQueueWhoseWakeUpWasLostIsSentInOrderByTheQueueJobAndKeptByRetention and WebhookFixture.HostAsync in the FluentCMS.Plugins.Webhooks.Tests project. Run the failing test alone, then with the full project, and trace how the host clock advance and recurring job runner affect RunDueJobsAsync. Done means the test passes in a full project run on main.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

area:testing plugin type:bug

Problem

WebhookRecoveryTests.AQueueWhoseWakeUpWasLostIsSentInOrderByTheQueueJobAndKeptByRetention fails when the whole FluentCMS.Plugins.Webhooks.Tests project runs. It fails on main as well (checked at 034616ae on Windows arm64, SQLite). It passes when run alone or with its class.

The test expects RunDueJobsAsync to run one job, the retention it enqueued, but it ran six. The other five were content.trash.purge, jobs.retention, idempotency.retention, activity.retention and webhooks.retention, all on the default queue. WebhookFixture.HostAsync moves the host's clock forward two days and pumps. The host's own job runner then fires the recurring jobs that became due, from its maintenance loop, after the pump has finished. They are still due when the test runs, so it counts them.

Proposal

Have HostAsync wait until the recurring jobs the clock move made due have fired and run, for example by firing them itself before it pumps. Or have the test count only the jobs it enqueued.

Acceptance

  • The test passes in a full run of the project, on main
Lingua principale
C#
Stelle
567
Fork
107
Merge medio
1h 19m
PR unite (30g)
353

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di fluentcms/FluentCMS

Tutte le issue di fluentcms/FluentCMS

Issue simili

Altre issue su C#

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.