Self-registered clients have no global cap, and an explicit shared-tenant authority passes the SSO check
维护者通常 1 天内回复
还没有人认领这个 Issue。
评估
- 难度
- 4/5
- 预计耗时
- 3-5 天
- 新手友好度
- 38/100
- Issue 类型
- 缺陷
- 描述清晰度
- 描述清楚
- 活跃度
- 活跃
- 技术栈
- csharp
调研方向
Start with src/FluentCMS.Core/Identity/Oidc/McpClients.cs, DynamicClientRegistration.cs, ClientRegistrationService.cs, and Identity/SsoOptions.cs; read the existing registration limits, cleanup, counting, and authority validation paths. Coordinate with the changes in #3272 and #3225, which touch the same code. Done means all acceptance checks pass, including tests for each behavior.
由索引模型根据 Issue 内容生成。
描述
Problem
- Self-registered clients have no global cap. Pending clients are capped (
Identity/Oidc/McpClients.cs:284), but in Open mode with a default role the cap is skipped (:281-287), and approved or rejected clients are never pruned. The only bound is an in-memory, per-address, per-instance hourly limiter (Identity/Oidc/DynamicClientRegistration.cs:65,327-370).CountPendingAsync(McpClients.cs:357-369) and the startupRemoveUnlistedAsync(Identity/Oidc/ClientRegistrationService.cs:59-69) read every application, so growth also costs time. - The shared-tenant check is skipped when
Authorityis set. It sits insideif (string.IsNullOrWhiteSpace(Authority))(Identity/SsoOptions.cs:145-152), so an explicit…/common/v2.0authority passes validation.
Paths are under src/FluentCMS.Core/.
Proposal
- A configurable cap on all self-registered clients, a job that prunes ones never used, and a count done in SQL.
- Run the shared-tenant check on the resolved authority.
Done together with #3272 and #3225, which change the same client and SSO code.
Acceptance
- Registration is refused at the cap in every registration mode
- A self-registered client never used within the configured period is removed
- Counting clients does not load them
- An explicit shared-tenant authority is refused at startup unless the tenant list is set
- Tests for each
Found in the code review of 17 Nov 2026.
- 主要语言
- C#
- 星标
- 569
- 派生
- 107
- 平均合并
- 2 小时 49 分钟
- 30 天内合并 PR
- 397
环境准备
- 提供 Dockerfile 或 Docker Compose 文件
- 有 Pull Request 模板
- 阅读贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
fluentcms/FluentCMS 的其他 Issue
-
area:host area:operations type:bug
难度 2/5 1-3 小时 新手友好度 78/100
维护者通常 1 天内回复
-
area:build security type:chore
难度 2/5 1-3 小时 新手友好度 78/100
维护者通常 1 天内回复
-
area:sdk security type:bug
难度 2/5 1-3 小时 新手友好度 78/100
维护者通常 1 天内回复
-
area:content security type:bug
难度 2/5 1-3 小时 新手友好度 82/100
维护者通常 1 天内回复
-
area:build type:bug
难度 2/5 1-3 小时 新手友好度 78/100
维护者通常 1 天内回复
查看 fluentcms/FluentCMS 的全部 Issue
相似的 Issue
-
难度 2/5 1-3 小时 新手友好度 75/100
维护者通常 1 天内回复
-
bug needs-triage
难度 2/5 1-3 小时 新手友好度 67/100
microsoft/microsoft-ui-reactor#1567 ·
维护者通常 1 天内回复
-
clawsweeper:fix-shape-clear clawsweeper:queueable-fix clawsweeper:source-repro impact:ux-friction issue-rating: 🦞 diamond lobster no-stale P2
难度 2/5 1-3 小时 新手友好度 76/100
openclaw/openclaw-windows-node#2287 · 2 条评论 · 1 个 reaction ·
维护者通常 1 天内回复
-
kind:ux needs-triage
难度 2/5 1-3 小时 新手友好度 66/100
elsa-workflows/elsa-foundation#4742 ·
维护者通常 1 天内回复
-
priority:P2
难度 2/5 1-3 小时 新手友好度 88/100