Self-registered clients have no global cap, and an explicit shared-tenant authority passes the SSO check

Abierto
#3,301 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
4/5
Tiempo estimado
3-5 días
Aptitud para principiantes
38/100
Tipo de issue
Error
Claridad
Bien especificado
Estado de actividad
Activo
Stack tecnológico
csharp

Línea de trabajo

Start with src/FluentCMS.Core/Identity/Oidc/McpClients.cs, DynamicClientRegistration.cs, ClientRegistrationService.cs, and Identity/SsoOptions.cs; read the existing registration limits, cleanup, counting, and authority validation paths. Coordinate with the changes in #3272 and #3225, which touch the same code. Done means all acceptance checks pass, including tests for each behavior.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

area:identity security type:bug

Problem

  1. Self-registered clients have no global cap. Pending clients are capped (Identity/Oidc/McpClients.cs:284), but in Open mode with a default role the cap is skipped (:281-287), and approved or rejected clients are never pruned. The only bound is an in-memory, per-address, per-instance hourly limiter (Identity/Oidc/DynamicClientRegistration.cs:65,327-370). CountPendingAsync (McpClients.cs:357-369) and the startup RemoveUnlistedAsync (Identity/Oidc/ClientRegistrationService.cs:59-69) read every application, so growth also costs time.
  2. The shared-tenant check is skipped when Authority is set. It sits inside if (string.IsNullOrWhiteSpace(Authority)) (Identity/SsoOptions.cs:145-152), so an explicit …/common/v2.0 authority passes validation.

Paths are under src/FluentCMS.Core/.

Proposal

  • A configurable cap on all self-registered clients, a job that prunes ones never used, and a count done in SQL.
  • Run the shared-tenant check on the resolved authority.

Done together with #3272 and #3225, which change the same client and SSO code.

Acceptance

  • Registration is refused at the cap in every registration mode
  • A self-registered client never used within the configured period is removed
  • Counting clients does not load them
  • An explicit shared-tenant authority is refused at startup unless the tenant list is set
  • Tests for each

Found in the code review of 17 Nov 2026.

Lenguaje dominante
C#
Estrellas
569
Forks
107
Merge medio
2 h 49 min
PR fusionados (30 d)
397

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de fluentcms/FluentCMS

Todos los issues de fluentcms/FluentCMS

Issues similares

Más issues de C#

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.