An untrusted proxy puts every client in one rate-limit bucket without warning

未关闭
#3,286 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

还没有人认领这个 Issue。

评估

难度
4/5
预计耗时
3-5 天
新手友好度
45/100
Issue 类型
功能
描述清晰度
基本清楚
活跃度
活跃
技术栈
csharp

调研方向

Start with ApiCaller.cs near line 90 and trace the forwarded-header configuration, startup report, and rate-limit policies described in the issue. Check how untrusted X-Forwarded-For and X-Forwarded-Proto headers are handled and how existing warnings and startup entries are produced. Done means one Warning per process and a startup-report entry for such requests; the proposal also calls for refusal metrics by policy.

由索引模型根据 Issue 内容生成。

描述

area:host area:operations type:feature

Problem

The pre-auth, auth, health and anonymous Delivery limits partition by Connection.RemoteIpAddress (ApiCaller.cs:90). Forwarded headers are off by default and, when on without known proxies, trust only loopback; the framework logs the ignored header at Debug. Behind nginx, Traefik or an ingress every user shares the proxy's address, so sign-ins and refreshes are limited to 20 a minute for the whole site.

Proposal

Log a Warning once per process, and add a startup-report entry, when a request carries X-Forwarded-For or X-Forwarded-Proto from an untrusted address; add rate-limit refusal metrics by policy.

Acceptance

  • The misconfiguration is reported at Warning and in the startup report

Found in the code review of 17 Nov 2026 (C2).

主要语言
C#
星标
569
派生
107
平均合并
2 小时 49 分钟
30 天内合并 PR
397

环境准备

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

fluentcms/FluentCMS 的其他 Issue

查看 fluentcms/FluentCMS 的全部 Issue

相似的 Issue

更多 C# Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。