An untrusted proxy puts every client in one rate-limit bucket without warning

Abierto
#3,286 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
4/5
Tiempo estimado
3-5 días
Aptitud para principiantes
45/100
Tipo de issue
Nueva funcionalidad
Claridad
Bastante claro
Estado de actividad
Activo
Stack tecnológico
csharp

Línea de trabajo

Start with ApiCaller.cs near line 90 and trace the forwarded-header configuration, startup report, and rate-limit policies described in the issue. Check how untrusted X-Forwarded-For and X-Forwarded-Proto headers are handled and how existing warnings and startup entries are produced. Done means one Warning per process and a startup-report entry for such requests; the proposal also calls for refusal metrics by policy.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

area:host area:operations type:feature

Problem

The pre-auth, auth, health and anonymous Delivery limits partition by Connection.RemoteIpAddress (ApiCaller.cs:90). Forwarded headers are off by default and, when on without known proxies, trust only loopback; the framework logs the ignored header at Debug. Behind nginx, Traefik or an ingress every user shares the proxy's address, so sign-ins and refreshes are limited to 20 a minute for the whole site.

Proposal

Log a Warning once per process, and add a startup-report entry, when a request carries X-Forwarded-For or X-Forwarded-Proto from an untrusted address; add rate-limit refusal metrics by policy.

Acceptance

  • The misconfiguration is reported at Warning and in the startup report

Found in the code review of 17 Nov 2026 (C2).

Lenguaje dominante
C#
Estrellas
569
Forks
107
Merge medio
2 h 49 min
PR fusionados (30 d)
397

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de fluentcms/FluentCMS

Todos los issues de fluentcms/FluentCMS

Issues similares

Más issues de C#

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.