[firebase_crashlytics]: Android reports the APK's libapp.so build ID for Dart code-push (Shorebird) patches, so their crashes use the wrong symbols
维护者通常 1 天内回复
还没有人认领这个 Issue。
评估
- 难度
- 4/5
- 预计耗时
- 3-5 天
- 新手友好度
- 48/100
- Issue 类型
- 功能
- 描述清晰度
- 描述清楚
- 活跃度
- 活跃
- 技术栈
- android, dart, firebase
- 领域
- mobile, observability
调研方向
Start by reading FlutterFirebaseCrashlyticsPlugin.recordError and ElfBuildIdReader in the Android Crashlytics plugin, then trace how the Dart VM snapshot build ID is obtained from the stack trace. Check the existing Android Crashlytics tests for build ID selection. Done when an opt-in lets Dart errors report the running Dart code's build ID and tests cover both the default ELF ID and the opt-in behavior.
由索引模型根据 Issue 内容生成。
描述
Is there an existing issue for this?
- I have searched the existing issues.
Which plugins are affected?
Crashlytics
Which platforms are affected?
Android
Description
When an app uses a Dart code-push tool such as Shorebird, Crashlytics symbolicates Dart crashes from a patch with the original release's symbols, so the stack trace shows unrelated functions with no warning.
A Shorebird patch is a full recompile of the app's Dart. It is downloaded at runtime and loaded instead of the libapp.so in the installed APK, which stays the release's. On Android, FlutterFirebaseCrashlyticsPlugin.recordError picks the build ID like this:
// Prefer the ELF build ID from libapp.so over the Dart VM's snapshot build ID.
// The firebase-crashlytics-buildtools JAR uses the ELF build ID when uploading symbols,
// so we must report the same ID for Crashlytics to match them.
val effectiveBuildId = elfBuildId ?: dartBuildId
elfBuildId is read by ElfBuildIdReader from the APK's libapp.so, so for a patched app it is always the release's build ID, even though the code that crashed came from the patch. Uploading the patch's symbols with firebase crashlytics:symbols:upload doesn't help, because the event never carries the patch's build ID. Every frame from a patch is decoded against the wrong symbol file, including frames from code the patch didn't change, since a recompile moves it.
Expected: a way to have the event carry the build ID of the Dart code that is actually running, so the patch's uploaded symbols are used.
Actual: the event always carries the APK's libapp.so build ID.
I understand why the ELF ID is preferred by default, so I'm not asking to change the default. An opt-in would be enough, for example:
- an option to prefer the Dart VM's snapshot build ID (
dartBuildId, from the stack trace'sbuild_id:line) over the ELF one, or - an API to set the build ID reported with Dart errors, which an app could set from its code-push SDK when a patch is running.
Reproducing the issue
- Create a Shorebird release of an Android app with
firebase_crashlytics, built with--obfuscate --split-debug-info, and upload its symbols to Crashlytics. - Publish a Shorebird patch whose new code throws, e.g.
throw StateError('patch crash test')from a new function called on a button tap. - Install the release, restart it twice so the patch is running, and trigger the error.
- In Crashlytics, the event's plain-text stack trace shows the release's
BuildId(it matcheslibapp.sopulled from the device, not the patch's symbol file), and the function names come from the release, e.g. the new throwing function appears as an unrelated existing method. - Passing the same
pcoffsets tollvm-symbolizerwith the patch's symbol file gives the correct trace, with the throwing function on top.
Firebase Core version
4.15.0 (firebase_crashlytics 5.4.0)
Flutter Version
3.47.7 (Shorebird's Flutter fork, Shorebird CLI 1.6.134)
Relevant Log Output
No response
Flutter dependencies
No response
Additional context and comments
iOS has a related gap, but that one isn't in the plugin: Crashlytics only symbolicates iOS Dart frames through dSYMs, and a Shorebird patch has no dSYM, so patched iOS frames stay as raw abs … virt … lines. I'll raise that through Firebase Support.
- 主要语言
- Dart
- 星标
- 9.3k
- 派生
- 4.1k
- 平均合并
- 2 天 10 小时
- 30 天内合并 PR
- 78
环境准备
- 没有 Dockerfile 或 Docker Compose 文件
- 有 Pull Request 模板
- 阅读贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
firebase/flutterfire 的其他 Issue
-
🚀 [firebase_core] Bump Firebase C++ SDK (14.1.0 → 14.2.0)可能已有人在做 @SelaseKay 今天认领。 未关闭Needs Attention type: enhancement
难度 2/5 1-3 小时 新手友好度 70/100
firebase/flutterfire#18977 · 1 条评论 ·
维护者通常 1 天内回复
-
[firebase_core_web]: Firebase.initializeApp never completes when a Firebase JS SDK script fails to load可能已有人在做 @LasseLegarth 于 5 天前认领。 未关闭Needs Attention platform: web plugin: core reproduced type: bug
难度 2/5 1-3 小时 新手友好度 62/100
firebase/flutterfire#18964 · 1 条评论 ·
维护者通常 1 天内回复
-
blocked: external dependency platform: web plugin: ai type: bug
难度 4/5 3-5 天 新手友好度 48/100
firebase/flutterfire#18938 · 2 条评论 ·
维护者通常 1 天内回复
-
[cloud_firestore][Windows] Invalid field names (empty or `__x__`) close the app instead of throwing a FirebaseException可能已有人在做 @SelaseKay 于 5 天前认领。 未关闭Needs Attention platform: windows plugin: cloud_firestore reproduced type: bug type: crash
难度 4/5 3-5 天 新手友好度 52/100
firebase/flutterfire#18928 · 1 条评论 ·
维护者通常 1 天内回复
-
Needs Attention plugin: ai type: enhancement
难度 3/5 1-2 天 新手友好度 67/100
firebase/flutterfire#18917 ·
维护者通常 1 天内回复
查看 firebase/flutterfire 的全部 Issue
相似的 Issue
-
documentation
难度 2/5 1-3 小时 新手友好度 82/100
-
难度 2/5 1-3 小时 新手友好度 67/100
-
agent: is checked on a wrapper holding several checkables answers from the first one in tree order未关闭bug
难度 2/5 1-3 小时 新手友好度 76/100
AlphaWaveSystems/flutter-probe#865 ·
维护者通常 1 天内回复
-
bug
难度 2/5 1-3 小时 新手友好度 65/100
ubuntu/app-center#2306 ·
维护者通常 1 天内回复
-
enhancement
难度 2/5 1-3 小时 新手友好度 64/100
spotiflacapp/SpotiFLAC-Mobile#923 ·