[firebase_crashlytics]: Android reports the APK's libapp.so build ID for Dart code-push (Shorebird) patches, so their crashes use the wrong symbols
I maintainer di solito rispondono entro 1 giorno
Nessuno ha ancora preso questa issue.
Valutazione
- Difficoltà
- 4/5
- Tempo stimato
- 3-5 giorni
- Idoneità per principianti
- 48/100
- Tipo di issue
- Funzionalità
- Chiarezza
- Specificata chiaramente
- Stato di attività
- Attiva
- Stack tecnologico
- android, dart, firebase
- Ambito
- mobile, observability
Direzione di ricerca
Start by reading FlutterFirebaseCrashlyticsPlugin.recordError and ElfBuildIdReader in the Android Crashlytics plugin, then trace how the Dart VM snapshot build ID is obtained from the stack trace. Check the existing Android Crashlytics tests for build ID selection. Done when an opt-in lets Dart errors report the running Dart code's build ID and tests cover both the default ELF ID and the opt-in behavior.
Scritto dal modello di indicizzazione a partire dal testo della issue.
Descrizione
Is there an existing issue for this?
- I have searched the existing issues.
Which plugins are affected?
Crashlytics
Which platforms are affected?
Android
Description
When an app uses a Dart code-push tool such as Shorebird, Crashlytics symbolicates Dart crashes from a patch with the original release's symbols, so the stack trace shows unrelated functions with no warning.
A Shorebird patch is a full recompile of the app's Dart. It is downloaded at runtime and loaded instead of the libapp.so in the installed APK, which stays the release's. On Android, FlutterFirebaseCrashlyticsPlugin.recordError picks the build ID like this:
// Prefer the ELF build ID from libapp.so over the Dart VM's snapshot build ID.
// The firebase-crashlytics-buildtools JAR uses the ELF build ID when uploading symbols,
// so we must report the same ID for Crashlytics to match them.
val effectiveBuildId = elfBuildId ?: dartBuildId
elfBuildId is read by ElfBuildIdReader from the APK's libapp.so, so for a patched app it is always the release's build ID, even though the code that crashed came from the patch. Uploading the patch's symbols with firebase crashlytics:symbols:upload doesn't help, because the event never carries the patch's build ID. Every frame from a patch is decoded against the wrong symbol file, including frames from code the patch didn't change, since a recompile moves it.
Expected: a way to have the event carry the build ID of the Dart code that is actually running, so the patch's uploaded symbols are used.
Actual: the event always carries the APK's libapp.so build ID.
I understand why the ELF ID is preferred by default, so I'm not asking to change the default. An opt-in would be enough, for example:
- an option to prefer the Dart VM's snapshot build ID (
dartBuildId, from the stack trace'sbuild_id:line) over the ELF one, or - an API to set the build ID reported with Dart errors, which an app could set from its code-push SDK when a patch is running.
Reproducing the issue
- Create a Shorebird release of an Android app with
firebase_crashlytics, built with--obfuscate --split-debug-info, and upload its symbols to Crashlytics. - Publish a Shorebird patch whose new code throws, e.g.
throw StateError('patch crash test')from a new function called on a button tap. - Install the release, restart it twice so the patch is running, and trigger the error.
- In Crashlytics, the event's plain-text stack trace shows the release's
BuildId(it matcheslibapp.sopulled from the device, not the patch's symbol file), and the function names come from the release, e.g. the new throwing function appears as an unrelated existing method. - Passing the same
pcoffsets tollvm-symbolizerwith the patch's symbol file gives the correct trace, with the throwing function on top.
Firebase Core version
4.15.0 (firebase_crashlytics 5.4.0)
Flutter Version
3.47.7 (Shorebird's Flutter fork, Shorebird CLI 1.6.134)
Relevant Log Output
No response
Flutter dependencies
No response
Additional context and comments
iOS has a related gap, but that one isn't in the plugin: Crashlytics only symbolicates iOS Dart frames through dSYMs, and a Shorebird patch has no dSYM, so patched iOS frames stay as raw abs … virt … lines. I'll raise that through Firebase Support.
- Lingua principale
- Dart
- Stelle
- 9.3k
- Fork
- 4.1k
- Merge medio
- 2g 10h
- PR unite (30g)
- 78
Preparare l'ambiente
- Nessun Dockerfile né file Docker Compose
- Ha un modello di pull request
- Leggi la guida per i contributori
Come iniziare
- Leggi tutta la issue e poi la guida ai contributi del progetto.
- Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
- Fai un fork del repository e lavora su un branch.
- Apri una pull request che faccia riferimento al numero della issue.
Altre issue di firebase/flutterfire
-
🚀 [firebase_core] Bump Firebase C++ SDK (14.1.0 → 14.2.0)Forse già presa @SelaseKay l’ha presa oggi. ApertaNeeds Attention type: enhancement
Difficoltà 2/5 1-3 ore Idoneità per principianti 70/100
firebase/flutterfire#18977 · 1 commento ·
I maintainer di solito rispondono entro 1 giorno
-
[firebase_core_web]: Firebase.initializeApp never completes when a Firebase JS SDK script fails to loadForse già presa @LasseLegarth l’ha presa 5 giorni fa. ApertaNeeds Attention platform: web plugin: core reproduced type: bug
Difficoltà 2/5 1-3 ore Idoneità per principianti 62/100
firebase/flutterfire#18964 · 1 commento ·
I maintainer di solito rispondono entro 1 giorno
-
blocked: external dependency platform: web plugin: ai type: bug
Difficoltà 4/5 3-5 giorni Idoneità per principianti 48/100
firebase/flutterfire#18938 · 2 commenti ·
I maintainer di solito rispondono entro 1 giorno
-
[cloud_firestore][Windows] Invalid field names (empty or `__x__`) close the app instead of throwing a FirebaseExceptionForse già presa @SelaseKay l’ha presa 5 giorni fa. ApertaNeeds Attention platform: windows plugin: cloud_firestore reproduced type: bug type: crash
Difficoltà 4/5 3-5 giorni Idoneità per principianti 52/100
firebase/flutterfire#18928 · 1 commento ·
I maintainer di solito rispondono entro 1 giorno
-
Needs Attention plugin: ai type: enhancement
Difficoltà 3/5 1-2 giorni Idoneità per principianti 67/100
firebase/flutterfire#18917 ·
I maintainer di solito rispondono entro 1 giorno
Tutte le issue di firebase/flutterfire
Issue simili
-
documentation
Difficoltà 2/5 1-3 ore Idoneità per principianti 82/100
-
[BUG] 172.2* 排除域名包含公网IPAperta
Difficoltà 2/5 1-3 ore Idoneità per principianti 67/100
-
agent: is checked on a wrapper holding several checkables answers from the first one in tree orderApertabug
Difficoltà 2/5 1-3 ore Idoneità per principianti 76/100
AlphaWaveSystems/flutter-probe#865 ·
I maintainer di solito rispondono entro 1 giorno
-
bug
Difficoltà 2/5 1-3 ore Idoneità per principianti 65/100
ubuntu/app-center#2306 ·
I maintainer di solito rispondono entro 1 giorno
-
enhancement
Difficoltà 2/5 1-3 ore Idoneità per principianti 64/100
spotiflacapp/SpotiFLAC-Mobile#923 ·