Security hardening backlog: Windows cmd injection, config load/create path scoping, unbounded session store, barcode dir validation, server-only exposure
维护者通常 1 天内回复
还没有人认领这个 Issue。
评估
- 难度
- 4/5
- 预计耗时
- 3-5 天
- 新手友好度
- 40/100
调研方向
The issue lists six security fixes with file:line refs, e.g. src/profiles/utils/file_utils.py:469-471 and web/src/utils/barcodeScanner.ts:82-84. Read each named module, reproduce the vector, and apply the suggested shell-free or validation fix. Done when all checklist boxes are checked and tests pass.
由索引模型根据 Issue 内容生成。
描述
Companion to the three high-severity issues. Each item below is MED/LOW on its own; all verified against the code.
- Windows
cmd /c startinjection.src/profiles/utils/file_utils.py:469-471runs["cmd", "/c", "start", "", path, *tokens]; tokens fromlaunch-with-argsareshlex.split-ed but then re-parsed by cmd.exe — a token like&calcor%WINDIR%executes arbitrary commands. Alsosrc/profiles/core/actions.py:495-499buildscmd /K "cd /D {path}"— a directory namedx & calc(legal on Windows) injects via/api/actions/open-terminal. Fix: shell-free APIs (os.startfile/ShellExecuteEx), separate argv flags, or reject cmd metacharacters inargson Windows. - Config load/create accept arbitrary absolute paths.
POST /api/config/loadaccepts any*.profiles*path on disk (routes/config.py:143-148);POST /api/config/createdoesmkdir(parents=True)+ writes the starter template at anydirectory(config.py:191-211→launch/creation.py:47-68). Scope to configured/active directories, or token-gate. - Workflow session store is unbounded.
_sessions: dict(routes/workflow.py:74) is never pruned → memory growth from repeated starts. Cap + TTL (also relates to #24's dangling sessions). - Barcode
dir=sets an arbitrary scan target.web/src/utils/barcodeScanner.ts:82-84+App.tsx:1046-1106: a scanned barcode can setdirto any path (e.g. a UNC\\attacker\share, causing NTLM leakage on Windows) and auto-triggers a scan. Validate scheme/plain paths; warn before scanning non-local targets. -
--server-onlybinds0.0.0.0with no auth (app.py:262; LAN banner atapp.py:296-299). If LAN sharing is a feature, require the instance token and print a token-scoped URL; otherwise default to loopback. - Handoff manifest hardening.
desktop/instance.py:47-64has good hygiene (mkstemp 0600, atomic replace) butread_manifestaccepts any syntactically valid JSON with a live PID — a local process could pre-place a manifest for the fallback port and hijack a handoff. Verify owner == current user and mtime after server start.
- 主要语言
- Python
- 星标
- 1
- 派生
- 1
- 平均合并
- 4 小时 46 分钟
- 30 天内合并 PR
- 55
环境准备
这个项目没有提供开发容器、Dockerfile 或贡献指南,环境需要你自己搭建:先看它的 README,通用步骤见我们的新手贡献指南。
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
falbany/ProFiles 的其他 Issue
-
难度 2/5 1-3 小时 新手友好度 78/100
falbany/ProFiles#187 · 1 条评论 ·
维护者通常 1 天内回复
-
bug
难度 2/5 1-3 小时 新手友好度 78/100
维护者通常 1 天内回复
-
bug frontend
难度 2/5 1-3 小时 新手友好度 78/100
维护者通常 1 天内回复
-
bug frontend
难度 2/5 1-3 小时 新手友好度 84/100
维护者通常 1 天内回复
-
bug frontend
难度 2/5 1-3 小时 新手友好度 78/100
维护者通常 1 天内回复
相似的 Issue
-
难度 2/5 1-3 小时 新手友好度 74/100
ip-tools/patzilla#219 · 2 条评论 ·
维护者通常 1 天内回复
-
EPSSClient commits to its SQLite cache once per score: a 100-CVE bulk fetch makes 101 disk flushes未关闭priority:p3 technical-debt
难度 2/5 1-3 小时 新手友好度 82/100
jimmy058910/jmo-security-repo#1673 ·
维护者通常 1 天内回复
-
enhancement ready
难度 2/5 1-3 小时 新手友好度 86/100
-
integration: frontier_silicon
难度 2/5 1-3 小时 新手友好度 70/100
home-assistant/core#193176 · 2 条评论 ·
维护者通常 1 天内回复
-
task create and task update take --body-file and --stdin可能已有人在做 @JuanBarriosS 今天认领。 未关闭cli enhancement good first issue help wanted
难度 2/5 1-3 小时 新手友好度 92/100
pyrite-wiki/pyrite#1687 · 1 条评论 ·
维护者通常 1 天内回复