Security hardening backlog: Windows cmd injection, config load/create path scoping, unbounded session store, barcode dir validation, server-only exposure

Aperta
#29 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
4/5
Tempo stimato
3-5 giorni
Idoneità per principianti
40/100
Tipo di issue
Bug
Chiarezza
Abbastanza chiara
Stato di attività
Attiva
Stack tecnologico
python, typescript

Direzione di ricerca

The issue lists six security fixes with file:line refs, e.g. src/profiles/utils/file_utils.py:469-471 and web/src/utils/barcodeScanner.ts:82-84. Read each named module, reproduce the vector, and apply the suggested shell-free or validation fix. Done when all checklist boxes are checked and tests pass.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

enhancement security

Companion to the three high-severity issues. Each item below is MED/LOW on its own; all verified against the code.

  • Windows cmd /c start injection. src/profiles/utils/file_utils.py:469-471 runs ["cmd", "/c", "start", "", path, *tokens]; tokens from launch-with-args are shlex.split-ed but then re-parsed by cmd.exe — a token like &calc or %WINDIR% executes arbitrary commands. Also src/profiles/core/actions.py:495-499 builds cmd /K "cd /D {path}" — a directory named x & calc (legal on Windows) injects via /api/actions/open-terminal. Fix: shell-free APIs (os.startfile/ShellExecuteEx), separate argv flags, or reject cmd metacharacters in args on Windows.
  • Config load/create accept arbitrary absolute paths. POST /api/config/load accepts any *.profiles* path on disk (routes/config.py:143-148); POST /api/config/create does mkdir(parents=True) + writes the starter template at any directory (config.py:191-211 → launch/creation.py:47-68). Scope to configured/active directories, or token-gate.
  • Workflow session store is unbounded. _sessions: dict (routes/workflow.py:74) is never pruned → memory growth from repeated starts. Cap + TTL (also relates to #24's dangling sessions).
  • Barcode dir= sets an arbitrary scan target. web/src/utils/barcodeScanner.ts:82-84 + App.tsx:1046-1106: a scanned barcode can set dir to any path (e.g. a UNC \\attacker\share, causing NTLM leakage on Windows) and auto-triggers a scan. Validate scheme/plain paths; warn before scanning non-local targets.
  • --server-only binds 0.0.0.0 with no auth (app.py:262; LAN banner at app.py:296-299). If LAN sharing is a feature, require the instance token and print a token-scoped URL; otherwise default to loopback.
  • Handoff manifest hardening. desktop/instance.py:47-64 has good hygiene (mkstemp 0600, atomic replace) but read_manifest accepts any syntactically valid JSON with a live PID — a local process could pre-place a manifest for the fallback port and hijack a handoff. Verify owner == current user and mtime after server start.
Lingua principale
Python
Stelle
1
Fork
1
Merge medio
4h 46m
PR unite (30g)
55

Preparare l'ambiente

Questo progetto non fornisce container di sviluppo, Dockerfile né guida per i contributori, quindi l'ambiente è a tuo carico: parti dal suo README e consulta la nostra guida al primo contributo per i passaggi generali.

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di falbany/ProFiles

Tutte le issue di falbany/ProFiles

Issue simili

Altre issue su Python

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.