User Namespaces and Common Methods project settings have no effect on stacking
维护者通常 1 天内回复
还没有人认领这个 Issue。
评估
调研方向
Read EventPipeline.cs and 20_ErrorPlugin.cs to follow how project settings reach the event context, then check the settings access patterns for @@DataExclusions, @@UserAgentBotPatterns and @@IncludePrivateInformation. Update the reads for UserNamespaces and CommonMethods with the stated fallback, and verify stacking for both configuration settings and existing data properties; consider whether migrating Project.Data is needed for the settings page.
由索引模型根据 Issue 内容生成。
描述
Problem
The User Namespaces and Common Methods fields on the project settings page are saved, but the event pipeline never sees them, so they don't affect stacking.
- The UI saves both as project configuration settings:
settings/+page.svelte#L79and#L131callupdateOrRemoveProjectConfig(...). EventPipelineonly copies organization and projectDatainto the event context:EventPipeline.cs#L49-L58.ErrorPluginreads them from the context properties:20_ErrorPlugin.cs#L35-L43.
Reproduction
Verified against exceptionless/exceptionless:8.10.0 (StackingSignatureE2ETest):
POST /api/v2/projects/{id}/config?key=UserNamespaceswithcom.example(what the UI does). Submit an error thrown fromInteger.parseIntcalled bycom.example.Foo. Result: the signature method is stilljava.lang.NumberFormatException.forInputString(...).POST /api/v2/projects/{id}/data?key=UserNamespaceswithcom.example. Submit the same error. Result: the signature method iscom.example.Foo.parse(...)as expected.
Proposal
ErrorPlugin should read UserNamespaces and CommonMethods from context.Project.Configuration.Settings, falling back to the existing data properties for backwards compatibility. That's also how @@DataExclusions, @@UserAgentBotPatterns and @@IncludePrivateInformation are read.
Optionally migrate existing Project.Data values into the configuration so the settings page shows them.
Note: configuration settings are also sent to clients by /projects/config. That's harmless, since clients ignore keys they don't know. Hiding them from the client-configuration table is already handled (config-options.svelte.ts#L61).
- 主要语言
- C#
- 星标
- 2.5k
- 派生
- 508
- 平均合并
- 2 天 17 小时
- 30 天内合并 PR
- 40
环境准备
在浏览器里用你自己的 GitHub 账号启动这个项目的开发容器。
- 提供 Dockerfile 或 Docker Compose 文件
- 没有 Pull Request 模板
- 阅读贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
exceptionless/Exceptionless 的其他 Issue
-
bug documentation
难度 2/5 1-3 小时 新手友好度 78/100
exceptionless/Exceptionless#2707 ·
维护者通常 1 天内回复
-
enhancement
难度 2/5 1-3 小时 新手友好度 85/100
exceptionless/Exceptionless#2706 ·
维护者通常 1 天内回复
-
bug
难度 2/5 1-3 小时 新手友好度 84/100
exceptionless/Exceptionless#2705 ·
维护者通常 1 天内回复
-
bug
难度 2/5 1-3 小时 新手友好度 88/100
exceptionless/Exceptionless#2704 ·
维护者通常 1 天内回复
-
bug
难度 2/5 1-3 小时 新手友好度 73/100
exceptionless/Exceptionless#2703 ·
维护者通常 1 天内回复
查看 exceptionless/Exceptionless 的全部 Issue
相似的 Issue
-
possible bug
难度 2/5 1-3 小时 新手友好度 74/100
-
Include host.wslc.internal in the HTTPS development certificate可能已有人在做 @afscrome 今天认领。 未关闭area-commandlinetools
难度 2/5 1-3 小时 新手友好度 70/100
dotnet/aspnetcore#70122 · 1 条评论 ·
维护者通常 1 天内回复
-
:1st_place_medal: good first issue :cowboy_hat_face: refactor :roller_coaster: enhancement
难度 2/5 1-3 小时 新手友好度 68/100
ApplETS/Backend-Hello#78 ·
-
难度 2/5 1-3 小时 新手友好度 74/100
维护者通常 2 天内回复
-
status/triage
难度 2/5 1-3 小时 新手友好度 85/100
Altinn/altinn-studio#21642 ·
维护者通常 1 天内回复