Reject deprecated Needs inventory inputs in docs(data)

未关闭
#1,018 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

还没有人认领这个 Issue。

评估

难度
4/5
预计耗时
3-5 天
新手友好度
47/100
Issue 类型
重构
描述清晰度
描述清楚
活跃度
活跃
技术栈
python
领域
tooling

调研方向

Start at the public macro boundary in docs.bzl and read the deprecation documented in #897; locate the consumers and fixtures that pass inventory labels through data. Migrate those inputs to external_needs, then trace the interactive build and Needs export paths to identify the implicit imports to remove. Done means inventory labels in data are rejected with a diagnostic, explicit imports and ordinary data files still work, and the API and migration docs plus coverage are updated.

由索引模型根据 Issue 内容生成。

描述

intentionally-limited

Needs inventories should be imported explicitly through docs(external_needs = [...]). Passing inventory targets through docs(data = [...]) is deprecated but still accepted, leaving two routes for the same dependency and retaining compatibility plumbing.

The deprecation is documented in #897 and reported at the public macro boundary in docs.bzl. Remove this compatibility route in a breaking release.

Acceptance criteria:

  • Migrate remaining consumers and fixtures from inventory labels in data to external_needs.
  • Reject recognized Needs inventory labels in docs(data = [...]) with a clear diagnostic pointing to external_needs.
  • Remove the implicit inventory import from data in both interactive builds and Needs export actions.
  • Preserve ordinary supporting/runtime data files and existing supported external_needs inputs.
  • Cover the rejection and successful explicit import, and update the API and migration documentation.

Keep the scope limited to the deprecated data route. Removing the legacy needs_json label from explicit external_needs is a separate decision. Removing bundle data mounts is also a separate change.

主要语言
Python
星标
11
派生
39
平均合并
1 天 13 小时
30 天内合并 PR
46

环境准备

在 Codespaces 中打开

在浏览器里用你自己的 GitHub 账号启动这个项目的开发容器。

  • 没有 Dockerfile 或 Docker Compose 文件
  • 有 Pull Request 模板
  • 没有贡献指南

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

eclipse-score/docs-as-code 的其他 Issue

查看 eclipse-score/docs-as-code 的全部 Issue

相似的 Issue

更多 Python Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。