Reject deprecated Needs inventory inputs in docs(data)

未關閉
#1,018 0 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視

維護者通常 1 天內回覆

還沒有人認領這個 Issue。

評估

難度
4/5
預估耗時
3-5 天
新手友好度
47/100
Issue 類型
重構
描述清晰度
描述清楚
活躍度
活躍
技術堆疊
python
領域
tooling

研究方向

Start at the public macro boundary in docs.bzl and read the deprecation documented in #897; locate the consumers and fixtures that pass inventory labels through data. Migrate those inputs to external_needs, then trace the interactive build and Needs export paths to identify the implicit imports to remove. Done means inventory labels in data are rejected with a diagnostic, explicit imports and ordinary data files still work, and the API and migration docs plus coverage are updated.

由索引模型根據 Issue 內容生成。

描述

intentionally-limited

Needs inventories should be imported explicitly through docs(external_needs = [...]). Passing inventory targets through docs(data = [...]) is deprecated but still accepted, leaving two routes for the same dependency and retaining compatibility plumbing.

The deprecation is documented in #897 and reported at the public macro boundary in docs.bzl. Remove this compatibility route in a breaking release.

Acceptance criteria:

  • Migrate remaining consumers and fixtures from inventory labels in data to external_needs.
  • Reject recognized Needs inventory labels in docs(data = [...]) with a clear diagnostic pointing to external_needs.
  • Remove the implicit inventory import from data in both interactive builds and Needs export actions.
  • Preserve ordinary supporting/runtime data files and existing supported external_needs inputs.
  • Cover the rejection and successful explicit import, and update the API and migration documentation.

Keep the scope limited to the deprecated data route. Removing the legacy needs_json label from explicit external_needs is a separate decision. Removing bundle data mounts is also a separate change.

主要語言
Python
星號
11
分支
39
平均合併
1 天 15 小時
30 天內合併 PR
50

環境準備

在 Codespaces 中開啟

在瀏覽器裡用你自己的 GitHub 帳號啟動這個專案的開發容器。

  • 沒有 Dockerfile 或 Docker Compose 檔案
  • 有 Pull Request 範本
  • 沒有貢獻指南

從這裡開始

  1. 先讀完整個 Issue,再讀專案的貢獻指南。
  2. 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
  3. Fork 儲存庫,在一個分支上完成修改。
  4. 送出 Pull Request,並在描述裡引用這個 Issue 編號。

eclipse-score/docs-as-code 的其他 Issue

查看 eclipse-score/docs-as-code 的全部 Issue

相似的 Issue

更多 Python Issue

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。