A pending document-link confirmation holds every Tool launch in the renderer
维护者通常 1 天内回复
还没有人认领这个 Issue。
评估
- 难度
- 4/5
- 预计耗时
- 1-2 天
- 新手友好度
- 48/100
- Issue 类型
- 缺陷
- 描述清晰度
- 描述清楚
- 活跃度
- 活跃
- 技术栈
- typescript
调研方向
Start with lib/src/components/wall/use-dor-control.ts, especially queueToolSpawn, launch(), and the confirmDocumentLinkOpen call. Trace how the queue and sourceChanged() interact when a confirmation stays open, then add a regression test through use-dor-control showing that another pane's Tool request can proceed. The issue is resolved when the test passes and a pending confirmation no longer blocks other launches.
由索引模型根据 Issue 内容生成。
描述
While the document-link confirmation added in #1201 is open, every other Tool request in that renderer waits for it. That includes dor tool and dor open from agents in other panes, OSC 367 previews, and approval completions.
Why it happens. queueToolSpawn is a module-level serial queue shared by every Wall in the renderer, and the whole launch() runs inside it. launch() now awaits confirmDocumentLinkOpen, which resolves only when the user answers, a later link replaces the request, or the request aborts. No timeout applies. The other awaits inside the queue (interruptToPrompt, typeToolCommand) are bounded by grace periods or timeouts. This one is bounded only by the user.
To trigger it. In a builtin:file Markdown Tool, click a relative link to an .html or .svg file and leave the dialog open. A dor tool … or dor open … from another pane in the same window then waits until the dialog is answered.
A possible fix. Run the handler lookup and the confirmation before taking the queue. Then, inside it, re-check sourceChanged(), which already runs after the confirmation today. The source's toolNavigating marker is set before the queue is taken, so that re-check still notices a source that moved on while the dialog was open. I haven't built this. The sandbox this nightly sweep ran in couldn't install dependencies, so I had no way to write the regression test through use-dor-control. That is why this is an issue rather than a PR.
@nedtwigg: do you want the confirmation moved outside the queue, or is holding other launches while it is open acceptable?
- 主要语言
- TypeScript
- 星标
- 5
- 派生
- 1
- 平均合并
- 10 小时 50 分钟
- 30 天内合并 PR
- 494
环境准备
这个项目没有提供开发容器、Dockerfile 或贡献指南，环境需要你自己搭建：先看它的 README，通用步骤见我们的新手贡献指南。
从这里开始
- 先读完整个 Issue，再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库，在一个分支上完成修改。
- 提交 Pull Request，并在描述里引用这个 Issue 编号。
diffplug/dormouse 的其他 Issue
-
难度 2/5 1-3 小时 新手友好度 86/100
diffplug/dormouse#912 · 1 条评论 ·
维护者通常 1 天内回复
-
难度 3/5 1-2 天 新手友好度 35/100
diffplug/dormouse#1373 · 1 条评论 ·
维护者通常 1 天内回复
-
难度 4/5 1-2 天 新手友好度 25/100
diffplug/dormouse#1235 · 1 条评论 ·
维护者通常 1 天内回复
-
enhancement security
难度 5/5 一周以上 新手友好度 25/100
diffplug/dormouse#1166 · 1 条评论 ·
维护者通常 1 天内回复
-
security-audit-status
难度 5/5 一周以上 新手友好度 5/100
diffplug/dormouse#1137 · 45 条评论 ·
维护者通常 1 天内回复
查看 diffplug/dormouse 的全部 Issue
相似的 Issue
-
bug hacktoberfest help wanted
难度 2/5 1-3 小时 新手友好度 82/100
libredb/libredb-studio#1941 ·
维护者通常 1 天内回复
-
chore other
难度 2/5 1-3 小时 新手友好度 78/100
alastair-smith/card-games#308 ·
维护者通常 1 天内回复
-
难度 1/5 1 小时以内 新手友好度 86/100
paperclipai/paperclip#17379 ·
维护者通常 1 天内回复
-
[good first issue, hacktoberfest] 🏯 Hacktoberfest Task - Add new Anime Quote 626 (good-first-issue)未关闭community first-timers-only good first issue hacktoberfest help wanted low hanging fruit up-for-grabs
难度 1/5 1 小时以内 新手友好度 76/100
lingdojo/kana-dojo#33040 · 1 条评论 · 5 个 reaction ·
维护者通常 1 天内回复
-
bug mobile ui
难度 2/5 1-3 小时 新手友好度 88/100
维护者通常 1 天内回复