Hacktoberfest 2026: los issues que los mantenedores marcaron para octubre, abiertos y aptos para principiantes. Explorar issues de Hacktoberfest

A pending document-link confirmation holds every Tool launch in the renderer

Abierto
  • ¿Algo no está bien?
#1,234 1 comentario 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
4/5
Tiempo estimado
1-2 días
Aptitud para principiantes
48/100
Tipo de issue
Error
Claridad
Bien especificado
Estado de actividad
Activo
Stack tecnológico
typescript
Área
desktop, developer-experience

Línea de trabajo

Start with lib/src/components/wall/use-dor-control.ts, especially queueToolSpawn, launch(), and the confirmDocumentLinkOpen call. Trace how the queue and sourceChanged() interact when a confirmation stays open, then add a regression test through use-dor-control showing that another pane's Tool request can proceed. The issue is resolved when the test passes and a pending confirmation no longer blocks other launches.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

While the document-link confirmation added in #1201 is open, every other Tool request in that renderer waits for it. That includes dor tool and dor open from agents in other panes, OSC 367 previews, and approval completions.

Why it happens. queueToolSpawn is a module-level serial queue shared by every Wall in the renderer, and the whole launch() runs inside it. launch() now awaits confirmDocumentLinkOpen, which resolves only when the user answers, a later link replaces the request, or the request aborts. No timeout applies. The other awaits inside the queue (interruptToPrompt, typeToolCommand) are bounded by grace periods or timeouts. This one is bounded only by the user.

To trigger it. In a builtin:file Markdown Tool, click a relative link to an .html or .svg file and leave the dialog open. A dor tool … or dor open … from another pane in the same window then waits until the dialog is answered.

A possible fix. Run the handler lookup and the confirmation before taking the queue. Then, inside it, re-check sourceChanged(), which already runs after the confirmation today. The source's toolNavigating marker is set before the queue is taken, so that re-check still notices a source that moved on while the dialog was open. I haven't built this. The sandbox this nightly sweep ran in couldn't install dependencies, so I had no way to write the regression test through use-dor-control. That is why this is an issue rather than a PR.

@nedtwigg: do you want the confirmation moved outside the queue, or is holding other launches while it is open acceptable?

Lenguaje dominante
TypeScript
Estrellas
5
Forks
1
Merge medio
10 h 51 min
PR fusionados (30 d)
507

Preparar el entorno

Este proyecto no incluye contenedor de desarrollo, Dockerfile ni guía de contribución, así que la configuración corre por tu cuenta: empieza por su README y consulta nuestra guía para la primera contribución para los pasos generales.

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de diffplug/dormouse

Todos los issues de diffplug/dormouse

Issues similares

Más issues de TypeScript

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.