Hacktoberfest 2026:维护者为十月标记出来的 issue,仍然开放、适合新手。 浏览 Hacktoberfest issue

[coverage] Conformance findings: ERRORRECOV-013

未关闭
#890 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

还没有人认领这个 Issue。

评估

难度
3/5
预计耗时
1-2 天
新手友好度
55/100
Issue 类型
缺陷
描述清晰度
基本清楚
活跃度
冷清
技术栈
python
领域
api, backend

调研方向

首先阅读 tests/ 下 coverage PR diff 中失败的测试 test_rate_limit_retry_count_zero_disables_retries,然后追踪用于 OpenSession 的 Thrift 重试配置。在持续返回 429 的情况下,显式重试次数为 1 时恰好产生一次 OpenSession 调用,同时默认策略仍会重试,并且错误包含指定的 rate-limit 文案,即表示完成。

由索引模型根据 Issue 内容生成。

描述

Summary

Surfaced by the multi-language coverage fan-out while conformance-testing these SPEC-IDs against databricks/databricks-sql-python. Each finding is committed as an expected-failure (xfail) test in the coverage PR — the test asserts the CORRECT (post-fix) behavior and stays red until THIS driver (databricks/databricks-sql-python) is fixed, then flips green as a tripwire.

Findings

  • ERRORRECOV-013 [thrift]: Thrift backend ignores an explicit disable-retries retry count: _retry_stop_after_attempts_count=1 still yields 2 OpenSession attempts under a persistent 429 (the count becomes urllib3's total, which raises MaxRetryError only after the extra attempt); the kernel/SEA backend honours the same kwarg correctly
    • failing test: test_rate_limit_retry_count_zero_disables_retries (see the coverage PR diff under tests/)

Reproduce & Expected

ERRORRECOV-013 — Validate the rate-limit retry COUNT knob (the reference driver's RateLimitRetry), as distinct from the retry TIME BUDGET that ERRORRECOV-010 covers.

Expected (per the shared spec):

  • [thrift] exactly 1 OpenSession call(s)
  • [sea] exactly 1 CreateSession call(s)
  • full assertion contract:
result:
- label: retries_disabled
  error:
    contains:
    - '429'
    - too many requests
    - rate
- label: default_policy
  error:
    contains:
    - '429'
    - too many requests
    - rate
protocol:
  thrift:
  - label: retries_disabled
    call_count:
      method: OpenSession
      expected: 1
  - label: default_policy
    call_min:
      method: OpenSession
      min: 2
  sea:
  - label: retries_disabled
    call_count:
      operation: CreateSession
      expected: 1
  - label: default_policy
    call_min:
      operation: CreateSession
      min: 2

Context

主要语言
Python
星标
233
派生
152
平均合并
21 小时 5 分钟
30 天内合并 PR
10

贡献指南

打开贡献指南

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

databricks/databricks-sql-python 的其他 Issue

查看 databricks/databricks-sql-python 的全部 Issue

相似的 Issue

更多 Python Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。