[coverage] Conformance findings: ERRORRECOV-013
還沒有人認領這個 Issue。
評估
研究方向
先閱讀 tests/ 下 coverage PR diff 中失敗的測試 test_rate_limit_retry_count_zero_disables_retries,然後追蹤用於 OpenSession 的 Thrift 重試設定。在持續回傳 429 的情況下,明確指定重試次數為 1 時恰好產生一次 OpenSession 呼叫,同時預設策略仍會重試,且錯誤包含指定的 rate-limit 文字,即表示完成。
由索引模型根據 Issue 內容生成。
描述
Summary
Surfaced by the multi-language coverage fan-out while conformance-testing these SPEC-IDs against databricks/databricks-sql-python. Each finding is committed as an expected-failure (xfail) test in the coverage PR — the test asserts the CORRECT (post-fix) behavior and stays red until THIS driver (databricks/databricks-sql-python) is fixed, then flips green as a tripwire.
Findings
- ERRORRECOV-013 [thrift]: Thrift backend ignores an explicit disable-retries retry count: _retry_stop_after_attempts_count=1 still yields 2 OpenSession attempts under a persistent 429 (the count becomes urllib3's
total, which raises MaxRetryError only after the extra attempt); the kernel/SEA backend honours the same kwarg correctly- failing test:
test_rate_limit_retry_count_zero_disables_retries(see the coverage PR diff undertests/)
- failing test:
Reproduce & Expected
ERRORRECOV-013 — Validate the rate-limit retry COUNT knob (the reference driver's RateLimitRetry), as distinct from the retry TIME BUDGET that ERRORRECOV-010 covers.
Expected (per the shared spec):
- [thrift] exactly 1
OpenSessioncall(s) - [sea] exactly 1
CreateSessioncall(s) - full assertion contract:
result:
- label: retries_disabled
error:
contains:
- '429'
- too many requests
- rate
- label: default_policy
error:
contains:
- '429'
- too many requests
- rate
protocol:
thrift:
- label: retries_disabled
call_count:
method: OpenSession
expected: 1
- label: default_policy
call_min:
method: OpenSession
min: 2
sea:
- label: retries_disabled
call_count:
operation: CreateSession
expected: 1
- label: default_policy
call_min:
operation: CreateSession
min: 2
Context
- The behavior was first fixed in a DIFFERENT driver — reference PR: https://github.com/databricks/databricks-odbc/pull/180 — which seeded the shared language-neutral spec. This issue tracks the same conformance gap in databricks/databricks-sql-python; the reference PR is for cross-referencing the intended behavior, NOT a change to this repo.
- Coverage PR carrying the reproducing xfail test(s): https://github.com/databricks/databricks-driver-test/pull/1109
- 主要語言
- Python
- 星號
- 233
- 分支
- 152
- 平均合併
- 21 小時 5 分鐘
- 30 天內合併 PR
- 10
貢獻指南
從這裡開始
- 先讀完整個 Issue,再讀專案的貢獻指南。
- 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
- Fork 儲存庫,在一個分支上完成修改。
- 送出 Pull Request,並在描述裡引用這個 Issue 編號。
databricks/databricks-sql-python 的其他 Issue
-
難度 2/5 1-3 小時 新手友好度 78/100
-
難度 2/5 1-3 小時 新手友好度 76/100
-
難度 2/5 1-3 小時 新手友好度 78/100
-
難度 2/5 1-3 小時 新手友好度 72/100
-
難度 2/5 1-3 小時 新手友好度 84/100
查看 databricks/databricks-sql-python 的全部 Issue
相似的 Issue
-
bug confirmed issue
難度 2/5 1-3 小時 新手友好度 75/100
open-webui/open-webui#30750 · 1 則留言 ·
-
難度 2/5 1-3 小時 新手友好度 75/100
-
enhancement
難度 2/5 1-3 小時 新手友好度 75/100
OpenwaterHealth/openmotion-bloodflow-app#604 · 1 則留言 ·
-
難度 2/5 1-3 小時 新手友好度 70/100
-
good first issue
難度 1/5 1 小時以內 新手友好度 90/100