Hacktoberfest 2026:维护者为十月标记出来的 issue,仍然开放、适合新手。 浏览 Hacktoberfest issue

[coverage] Conformance findings: STATEMENT-023,STATEMENT-025

未关闭
#527 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

还没有人认领这个 Issue。

评估

难度
4/5
预计耗时
3-5 天
新手友好度
45/100
Issue 类型
缺陷
描述清晰度
基本清楚
活跃度
活跃

调研方向

The issue describes two conformance test failures related to query timeout handling in the Thrift layer. Start by examining the failing tests in the coverage PR (linked). Look for the Thrift client code that sets TExecuteStatementReq.queryTimeout. For STATEMENT-025, validate that negative timeouts are rejected. For STATEMENT-023, ensure the timeout is enforced during query execution, not just set. The tests provide SQL to reproduce and expected YAML output.

由索引模型根据 Issue 内容生成。

描述

Summary

Surfaced by the multi-language coverage fan-out while conformance-testing these SPEC-IDs against databricks/databricks-sql-nodejs. Each finding is committed as an expected-failure (xfail) test in the coverage PR — the test asserts the CORRECT (post-fix) behavior and stays red until THIS driver (databricks/databricks-sql-nodejs) is fixed, then flips green as a tripwire.

Findings

  • STATEMENT-025 [thrift]: a negative queryTimeout is silently accepted and forwarded verbatim as TExecuteStatementReq.queryTimeout with no range validation, so the statement runs unbounded instead of the invalid value being reported to the caller
    • failing test: STATEMENT-025 — queryTimeout=0 is unlimited and a negative queryTimeout is rejected (see the coverage PR diff under tests/)
  • STATEMENT-023 [thrift]: queryTimeout is accepted but never enforced at execution on Thrift — the driver polls to the query's natural completion (23.9s against a 5s deadline) instead of aborting at ~the deadline, the same accepted-but-never-applied defect class as databricks-odbc#136
    • failing test: STATEMENT-023 — queryTimeout aborts a long query at ~the deadline and leaves the session usable (see the coverage PR diff under tests/)

Reproduce & Expected

STATEMENT-023 — Validates that a configured client-side query timeout is ENFORCED at execution time -- not merely stored and echoed back by the getter (STATEMENT-021 asserts only that some timeout error surfaces;…

Reproduce:

SELECT COUNT(*) FROM range(0, 40000000) a JOIN range(0, 40000000) b ON a.id % 5000 = b.id % 5000 -- timeout nonce <unique-per-run>
SELECT 1

Expected (per the shared spec):

  • completes without an exception
  • result has exactly 1 row(s)
  • full assertion contract:
result:
- label: timed_out
  error:
    contains:
    - timeout
    - timed out
    - cancel
- label: timed_out
  sql_state: HYT00
- label: timed_out
  elapsed_seconds_range:
    min: 4
    max: 25
- label: reused_statement
  no_exception: true
- label: reused_statement
  row_count: 1
STATEMENT-025 — Validates the BOUNDARY VALUES of the driver's client-side query-timeout surface -- the same surface STATEMENT-023 exercises with an ordinary finite deadline.

Reproduce:

SELECT 1 AS test_value
SELECT 1 AS test_value

Expected (per the shared spec):

  • completes without an exception
  • result has exactly 1 row(s)
  • col 0, row 0 == 1 (type Int32)
  • full assertion contract:
result:
- label: unlimited
  no_exception: true
- label: unlimited
  row_count: 1
- label: unlimited
  column:
    index: 0
    row: 0
    type: Int32
    equals: 1
- label: invalid
  exception_thrown: true

Context

主要语言
TypeScript
星标
36
派生
50
平均合并
13 小时 46 分钟
30 天内合并 PR
9

贡献指南

打开贡献指南

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

databricks/databricks-sql-nodejs 的其他 Issue

查看 databricks/databricks-sql-nodejs 的全部 Issue

相似的 Issue

更多 TypeScript Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。