[coverage] Conformance findings: STATEMENT-023,STATEMENT-025
維護者通常 1 天內回覆
還沒有人認領這個 Issue。
評估
- 難度
- 4/5
- 預估耗時
- 3-5 天
- 新手友好度
- 45/100
- Issue 類型
- 缺陷
- 描述清晰度
- 基本清楚
- 活躍度
- 活躍
- 技術堆疊
- nodejs, sql, typescript
- 領域
- backend, databases, testing-qa
研究方向
The issue describes two conformance test failures related to query timeout handling in the Thrift layer. Start by examining the failing tests in the coverage PR (linked). Look for the Thrift client code that sets TExecuteStatementReq.queryTimeout. For STATEMENT-025, validate that negative timeouts are rejected. For STATEMENT-023, ensure the timeout is enforced during query execution, not just set. The tests provide SQL to reproduce and expected YAML output.
由索引模型根據 Issue 內容生成。
描述
Summary
Surfaced by the multi-language coverage fan-out while conformance-testing these SPEC-IDs against databricks/databricks-sql-nodejs. Each finding is committed as an expected-failure (xfail) test in the coverage PR — the test asserts the CORRECT (post-fix) behavior and stays red until THIS driver (databricks/databricks-sql-nodejs) is fixed, then flips green as a tripwire.
Findings
- STATEMENT-025 [thrift]: a negative queryTimeout is silently accepted and forwarded verbatim as TExecuteStatementReq.queryTimeout with no range validation, so the statement runs unbounded instead of the invalid value being reported to the caller
- failing test:
STATEMENT-025 — queryTimeout=0 is unlimited and a negative queryTimeout is rejected(see the coverage PR diff undertests/)
- failing test:
- STATEMENT-023 [thrift]: queryTimeout is accepted but never enforced at execution on Thrift — the driver polls to the query's natural completion (23.9s against a 5s deadline) instead of aborting at ~the deadline, the same accepted-but-never-applied defect class as databricks-odbc#136
- failing test:
STATEMENT-023 — queryTimeout aborts a long query at ~the deadline and leaves the session usable(see the coverage PR diff undertests/)
- failing test:
Reproduce & Expected
STATEMENT-023 — Validates that a configured client-side query timeout is ENFORCED at execution time -- not merely stored and echoed back by the getter (STATEMENT-021 asserts only that some timeout error surfaces;…
Reproduce:
SELECT COUNT(*) FROM range(0, 40000000) a JOIN range(0, 40000000) b ON a.id % 5000 = b.id % 5000 -- timeout nonce <unique-per-run>
SELECT 1
Expected (per the shared spec):
- completes without an exception
- result has exactly 1 row(s)
- full assertion contract:
result:
- label: timed_out
error:
contains:
- timeout
- timed out
- cancel
- label: timed_out
sql_state: HYT00
- label: timed_out
elapsed_seconds_range:
min: 4
max: 25
- label: reused_statement
no_exception: true
- label: reused_statement
row_count: 1
STATEMENT-025 — Validates the BOUNDARY VALUES of the driver's client-side query-timeout surface -- the same surface STATEMENT-023 exercises with an ordinary finite deadline.
Reproduce:
SELECT 1 AS test_value
SELECT 1 AS test_value
Expected (per the shared spec):
- completes without an exception
- result has exactly 1 row(s)
- col 0, row 0 == 1 (type Int32)
- full assertion contract:
result:
- label: unlimited
no_exception: true
- label: unlimited
row_count: 1
- label: unlimited
column:
index: 0
row: 0
type: Int32
equals: 1
- label: invalid
exception_thrown: true
Context
- The behavior was first fixed in a DIFFERENT driver — reference PR: https://github.com/databricks/databricks-sql-go/pull/484 — which seeded the shared language-neutral spec. This issue tracks the same conformance gap in databricks/databricks-sql-nodejs; the reference PR is for cross-referencing the intended behavior, NOT a change to this repo.
- Coverage PR carrying the reproducing xfail test(s): https://github.com/databricks/databricks-driver-test/pull/1672
- 主要語言
- TypeScript
- 星號
- 37
- 分支
- 52
- 平均合併
- 1 天 47 分鐘
- 30 天內合併 PR
- 10
環境準備
- 沒有 Dockerfile 或 Docker Compose 檔案
- 沒有 Pull Request 範本
- 閱讀貢獻指南
從這裡開始
- 先讀完整個 Issue,再讀專案的貢獻指南。
- 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
- Fork 儲存庫,在一個分支上完成修改。
- 送出 Pull Request,並在描述裡引用這個 Issue 編號。
databricks/databricks-sql-nodejs 的其他 Issue
-
難度 2/5 1-3 小時 新手友好度 74/100
databricks/databricks-sql-nodejs#541 ·
維護者通常 1 天內回覆
-
難度 2/5 1-3 小時 新手友好度 78/100
databricks/databricks-sql-nodejs#526 ·
維護者通常 1 天內回覆
-
難度 2/5 1-3 小時 新手友好度 72/100
databricks/databricks-sql-nodejs#503 ·
維護者通常 1 天內回覆
-
engineer-bot
難度 2/5 1-3 小時 新手友好度 64/100
databricks/databricks-sql-nodejs#274 · 1 則留言 · 1 個 reaction ·
維護者通常 1 天內回覆
-
難度 3/5 1-2 天 新手友好度 55/100
databricks/databricks-sql-nodejs#540 ·
維護者通常 1 天內回覆
查看 databricks/databricks-sql-nodejs 的全部 Issue
相似的 Issue
-
by: ai-assisted frontend good-for: new-member spike
難度 2/5 1-3 小時 新手友好度 68/100
Northeastern-Electric-Racing/Argos#847 ·
維護者通常 4 天內回覆
-
難度 1/5 1-3 小時 新手友好度 84/100
SignalK/freeboard-sk#990 ·
維護者通常 1 天內回覆
-
[missing-inheritance] audit review (1 preset)可能已有人在做 @github-actions 今天認領。 未關閉
難度 1/5 1 小時以內 新手友好度 82/100
osmberlin/tagging-schema-browser#363 · 1 則留言 ·
維護者通常 1 天內回覆
-
enhancement
難度 2/5 1-3 小時 新手友好度 68/100
Albert-Weasker/niubigeo#205 ·
維護者通常 1 天內回覆
-
area/frontend area/v2 kind/bug priority/needs-triage
難度 2/5 1-3 小時 新手友好度 70/100
kubeflow/notebooks#1498 · 1 則留言 ·
維護者通常 1 天內回覆