Add xmlID as a property of at least note and rest objects when parsing xml/mei scores
维护者通常 1 天内回复
还没有人认领这个 Issue。
评估
调研方向
Start with the note.Note and note.Rest classes and the base object class that defines priority and sortTuple(), then check how the MusicXML and MEI parsers set element ids. Decide whether xmlID is a new string attribute or reuses priority, which the issue leaves open. Done means Note().xmlID returns None by default and the parsed id for notes and rests from an MEI or MusicXML file, with tests covering both cases.
由索引模型根据 Issue 内容生成。
描述
Motivation
Adding xmlID as a property would be useful to people who want to be able to go between music21 analysis and the score itself easily. This would greatly facilitate taking analysis done with music21 and encoding it into the symbolic notation file itself. This would be similar to how scores parsed in music21 have a "priority" property which is very useful when analyzing kern scores and wanting to go between music21 and the symbolic notation file easily.
Feature summary
Add xmlID as a property on objects of potentially all types, but at the very least notes and rests. Alternatively, since this only applies to xml and mei scores and those file types do not make use of the "priority" property, priority could serve double duty as the xml id property name. Though I believe priority is currently ints and xml ids would have to be strings, and xml ids can't be used in the sort order (object.sortTuple()) like priority can.
Proposed implementation
n = note.Note()
print(n.xmlID) # -> should print "None" for notes that aren't from an xml or mei file (or are but don't have the property), and the xml id string otherwise
Optionally, describe the implementation or the interface, in code or pseudocode.
Intent
I could potentially submit this pr myself if there is interest for it.
[√] I plan on implementing this myself.
[ ] I am willing to pay to have this feature added.
[ ] I am starting a discussion with the hope that community members will volunteer their time to create this. I understand that individuals work on features of interest to them and that this feature may never be implemented.
- 主要语言
- Python
- 星标
- 2.6k
- 派生
- 459
- 平均合并
- 12 小时 38 分钟
- 30 天内合并 PR
- 46
环境准备
在浏览器里用你自己的 GitHub 账号启动这个项目的开发容器。
- 没有 Dockerfile 或 Docker Compose 文件
- 有 Pull Request 模板
- 阅读贡献指南
从这里开始
- 先读完整个 Issue，再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库，在一个分支上完成修改。
- 提交 Pull Request，并在描述里引用这个 Issue 编号。
cuthbertLab/music21 的其他 Issue
-
enhancement
难度 2/5 1-3 小时 新手友好度 68/100
cuthbertLab/music21#2088 ·
维护者通常 1 天内回复
-
MusicXML import drops piano-family MIDI programs when the instrument name isn't recognized可能已有人在做 @Krishna221308 于 5 天前认领。 未关闭
难度 2/5 1-3 小时 新手友好度 72/100
cuthbertLab/music21#2084 · 6 条评论 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 78/100
cuthbertLab/music21#2055 · 3 条评论 ·
维护者通常 1 天内回复
-
Slur bezier-x/y from start element gets overwritten by stop element's values可能重新可做 @bingliscodes 于 23 天前认领，目前没有进行中的 PR。 未关闭
难度 2/5 1-3 小时 新手友好度 75/100
cuthbertLab/music21#2019 · 3 条评论 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 62/100
cuthbertLab/music21#1714 ·
维护者通常 1 天内回复
查看 cuthbertLab/music21 的全部 Issue
相似的 Issue
-
Support .aac audio uploads可能已有人在做 @julien731 今天认领。 未关闭feature
难度 2/5 1-3 小时 新手友好度 78/100
nimblehq/audio-transcriber#153 ·
-
help wanted
难度 2/5 1-3 小时 新手友好度 68/100
antonyrag/ragleap-core#1062 ·
-
needs-triage
难度 2/5 1-3 小时 新手友好度 76/100
gke-labs/kube-agents#4321 ·
维护者通常 1 天内回复
-
enhancement help wanted
难度 2/5 1-3 小时 新手友好度 76/100
Git-Hospital/githealthcheck#61 ·
维护者通常 1 天内回复
-
changelog investigate
难度 2/5 1-3 小时 新手友好度 67/100
ramnes/notion-sdk-py#433 ·