Add xmlID as a property of at least note and rest objects when parsing xml/mei scores
Los mantenedores suelen responder en 1 día
Nadie ha tomado este issue todavía.
Evaluación
- Dificultad
- 3/5
- Tiempo estimado
- 1-2 días
- Aptitud para principiantes
- 25/100
Línea de trabajo
Start with the note.Note and note.Rest classes and the base object class that defines priority and sortTuple(), then check how the MusicXML and MEI parsers set element ids. Decide whether xmlID is a new string attribute or reuses priority, which the issue leaves open. Done means Note().xmlID returns None by default and the parsed id for notes and rests from an MEI or MusicXML file, with tests covering both cases.
Escrito por el modelo de indexación a partir del texto del issue.
Descripción
Motivation
Adding xmlID as a property would be useful to people who want to be able to go between music21 analysis and the score itself easily. This would greatly facilitate taking analysis done with music21 and encoding it into the symbolic notation file itself. This would be similar to how scores parsed in music21 have a "priority" property which is very useful when analyzing kern scores and wanting to go between music21 and the symbolic notation file easily.
Feature summary
Add xmlID as a property on objects of potentially all types, but at the very least notes and rests. Alternatively, since this only applies to xml and mei scores and those file types do not make use of the "priority" property, priority could serve double duty as the xml id property name. Though I believe priority is currently ints and xml ids would have to be strings, and xml ids can't be used in the sort order (object.sortTuple()) like priority can.
Proposed implementation
n = note.Note()
print(n.xmlID) # -> should print "None" for notes that aren't from an xml or mei file (or are but don't have the property), and the xml id string otherwise
Optionally, describe the implementation or the interface, in code or pseudocode.
Intent
I could potentially submit this pr myself if there is interest for it.
[√] I plan on implementing this myself.
[ ] I am willing to pay to have this feature added.
[ ] I am starting a discussion with the hope that community members will volunteer their time to create this. I understand that individuals work on features of interest to them and that this feature may never be implemented.
- Lenguaje dominante
- Python
- Estrellas
- 2.6k
- Forks
- 459
- Merge medio
- 1 d 8 h
- PR fusionados (30 d)
- 39
Preparar el entorno
Inicia el contenedor de desarrollo del proyecto en tu navegador, con tu propia cuenta de GitHub.
- Sin Dockerfile ni archivo de Docker Compose
- Tiene una plantilla de pull request
- Leer la guía de contribución
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Más de cuthbertLab/music21
-
Midi bank number supportAbiertoenhancement
Dificultad 2/5 1-3 horas Aptitud para principiantes 68/100
cuthbertLab/music21#2088 ·
Los mantenedores suelen responder en 1 día
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 72/100
cuthbertLab/music21#2084 ·
Los mantenedores suelen responder en 1 día
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 78/100
cuthbertLab/music21#2055 · 3 comentarios ·
Los mantenedores suelen responder en 1 día
-
Slur bezier-x/y from start element gets overwritten by stop element's valuesQuizá libre de nuevo @bingliscodes la tomó hace 13 días y no hay ningún pull request abierto. Abierto
Dificultad 2/5 1-3 horas Aptitud para principiantes 75/100
cuthbertLab/music21#2019 · 3 comentarios ·
Los mantenedores suelen responder en 1 día
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 62/100
cuthbertLab/music21#1714 ·
Los mantenedores suelen responder en 1 día
Todos los issues de cuthbertLab/music21
Issues similares
-
Use mhctools predictor_required=False for saved-result rescoringPosiblemente ocupada @iskandr la tomó hoy. Abierto
Dificultad 2/5 1-3 horas Aptitud para principiantes 72/100
Los mantenedores suelen responder en 1 día
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 79/100
-
Dificultad 1/5 Menos de una hora Aptitud para principiantes 85/100
521xueweihan/HelloGitHub#4051 · 1 comentario ·
-
bug documentation
Dificultad 2/5 1-3 horas Aptitud para principiantes 78/100
awslabs/visual-asset-management-system#514 ·
Los mantenedores suelen responder en 1 día
-
backend bug spec:REQ-053
Dificultad 2/5 1-3 horas Aptitud para principiantes 66/100
nolte/kamerplanter#2547 ·
Los mantenedores suelen responder en 1 día