Docker: hadolint run through the `hadolint-docker` pre-commit hook is not credited

未关闭 适合新手
#260 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

还没有人认领这个 Issue。

评估

难度
2/5
预计耗时
1-3 小时
新手友好度
62/100
Issue 类型
缺陷
描述清晰度
描述清楚
活跃度
活跃
技术栈
docker, python, shell
领域
devtools

调研方向

从 project_validator/ecosystems/docker/tools.py 中的 hadolint 模式(第 30 行附近的 _HADOLINT_RUNS 匹配器)开始,并查看 project_validator/tools/pre_commit.py 第 48 行附近构建 argv 的代码,它会生成 (hook id, *words)。hook id hadolint-docker 应被识别为 hadolint,因此匹配器必须在现有的 hadolint 程序之外同时接受它。完成标准是:jupyter/docker-stacks 的语料用例报告 hadolint 正在运行,且测试套件仍然通过。

由索引模型根据 Issue 内容生成。

描述

jupyter/docker-stacks runs hadolint on every Dockerfile via the hadolint/hadolint repo's hadolint-docker hook, and CI runs pre-commit (the validator credits shellcheck, shfmt, black, ruff, flake8, mypy, basedpyright and markdownlint from the same file), yet static-analysis FAILs "hadolint is configured (.hadolint.yaml) but does not run" and security-scanning WARNs. The hook's expansion yields an argv (a docker run hadolint/hadolint … entry) that the hadolint pattern does not match.

Evidence from the corpus audit

jupyter/docker-stacks / static-analysis (Docker), security-scanning (Docker)
  • kind: FALSE_NEGATIVE
  • actual: FAIL: Docker: hadolint is configured (.hadolint.yaml) but does not run; WARN security-scanning: Docker: no
    code security scanning found in CI configuration
  • expected: PASS: hadolint runs on every Dockerfile through the hadolint-docker pre-commit hook, and CI runs
    pre-commit (the validator credits shellcheck, shfmt, black, ruff, flake8, mypy, basedpyright, markdownlint from the
    same file). The hook expansion yields argv ("hadolint-docker",), which does not match the hadolint program.
  • evidence: .pre-commit-config.yaml:113: - repo: https://github.com/hadolint/hadolint; :116:
    - id: hadolint-docker (and again at :122-125); .github/workflows/pre-commit.yml runs pre-commit;
    validator project_validator/tools/pre_commit.py:48: Invocation(argv=(str(hook["id"]), *words), ...);
    project_validator/ecosystems/docker/tools.py:30: _HADOLINT_RUNS = starts(("hadolint",)).
  • repro: .pre-commit-config.yaml with repo https://github.com/hadolint/hadolint, hook hadolint-docker;
    .hadolint.yaml; a step uses: pre-commit/action@<sha>; a Dockerfile.
  • confidence: high

Found by the regression-corpus audit (235 real repositories, one or more per ecosystem profile; corpus and expected results in corpus/). Evidence is quoted from the audited checkouts at the commits pinned in corpus/projects.toml; <checkouts>/<owner>__<repo> is such a checkout.

🤖 Generated with Claude Code

https://claude.ai/code/session_01ByTXNqDWdM7HzezrFtEvQt

主要语言
Python
星标
4
派生
1
平均合并
10 小时 41 分钟
30 天内合并 PR
79

环境准备

这个项目没有提供开发容器、Dockerfile 或贡献指南,环境需要你自己搭建:先看它的 README,通用步骤见我们的新手贡献指南。

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

cpp-best-practices/project_validator 的其他 Issue

查看 cpp-best-practices/project_validator 的全部 Issue

相似的 Issue

更多 Python Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。