Stream type enhancements: finalization

未关闭
#3,081 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

还没有人认领这个 Issue。

评估

难度
5/5
预计耗时
一周以上
新手友好度
25/100
Issue 类型
功能
描述清晰度
基本清楚
活跃度
停滞
技术栈
haskell
领域
backend

调研方向

Read the stream type definitions and the existing finalization support in the fold type, which the issue identifies as a precedent. Trace how take, terminating folds, and parRepeatM behave when a stream is not fully consumed. Done means defining and integrating stream finalization so early termination cleans up held resources, with tests covering those cases.

由索引模型根据 Issue 内容生成。

描述

api:breaking aspect:api aspect:streams priority:high

We use the bracket combinator to allocate a resource and use it inside the stream. When the stream stops or if an exception occurs the resource if freed automatically. However, if the stream is not fully consumed (e.g. if a fold terminates before the stream stops) then there is no way to cleanup any resources held by the stream other than GC. The only ways to do that is to either (1) drain the stream fully, or (2) let the GC clean it up.

Not sure if this is an important requirement but it can be solved by having a finalization function in the stream type just like we added one in the fold type. This will complicate all stream definitions though, just like it did in folds.

A stream would remain unconsumed on when take is used on it or a terminating fold is used on it which terminates before the stream terminates. If we use parRepeatM to generate a stream and then take just 1 element, the worker threads may still continue working until the stream is garbage collected, this could be problematic.

See also #585 for another stream type enhancement use case.

主要语言
Haskell
星标
926
派生
71
平均合并
6 小时 49 分钟
30 天内合并 PR
3

环境准备

  • 没有 Dockerfile 或 Docker Compose 文件
  • 没有 Pull Request 模板
  • 阅读贡献指南

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

composewell/streamly 的其他 Issue

查看 composewell/streamly 的全部 Issue

相似的 Issue

更多 Haskell Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。