Stream type enhancements: finalization

Abierto
#3,081 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
5/5
Tiempo estimado
Más de una semana
Aptitud para principiantes
25/100
Tipo de issue
Nueva funcionalidad
Claridad
Bastante claro
Estado de actividad
Estancado
Stack tecnológico
haskell
Área
backend

Línea de trabajo

Read the stream type definitions and the existing finalization support in the fold type, which the issue identifies as a precedent. Trace how take, terminating folds, and parRepeatM behave when a stream is not fully consumed. Done means defining and integrating stream finalization so early termination cleans up held resources, with tests covering those cases.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

api:breaking aspect:api aspect:streams priority:high

We use the bracket combinator to allocate a resource and use it inside the stream. When the stream stops or if an exception occurs the resource if freed automatically. However, if the stream is not fully consumed (e.g. if a fold terminates before the stream stops) then there is no way to cleanup any resources held by the stream other than GC. The only ways to do that is to either (1) drain the stream fully, or (2) let the GC clean it up.

Not sure if this is an important requirement but it can be solved by having a finalization function in the stream type just like we added one in the fold type. This will complicate all stream definitions though, just like it did in folds.

A stream would remain unconsumed on when take is used on it or a terminating fold is used on it which terminates before the stream terminates. If we use parRepeatM to generate a stream and then take just 1 element, the worker threads may still continue working until the stream is garbage collected, this could be problematic.

See also #585 for another stream type enhancement use case.

Lenguaje dominante
Haskell
Estrellas
926
Forks
71
Merge medio
6 h 49 min
PR fusionados (30 d)
3

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de composewell/streamly

Todos los issues de composewell/streamly

Issues similares

Más issues de Haskell

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.