An unreadable task payload stays stored with no way to clear it
维护者通常 1 天内回复
已经有一个关联 PR 被合并了。
- #87 来自 @codingjoe —— 已合并
评估
- 难度
- 5/5
- 预计耗时
- 一周以上
- 新手友好度
- 35/100
- Issue 类型
- 功能
- 描述清晰度
- 需要澄清
- 活跃度
- 活跃
- 技术栈
- python, redis
调研方向
Read threadmill/backends/redis.py, focusing on _reap_claimed_task and acquire, then trace the inspector's check_action handling for dequeue on RUNNING tasks. Resolve which terminal handling option is intended, and define done as giving operators an auditable way to clear the unreadable task without silently deleting it or repeatedly warning for the same ID.
由索引模型根据 Issue 内容生成。
描述
Found while reviewing PR #69 with the SuperJoe crew. Filed as out-of-scope there.
_reap_running_queue catches ImportError and skips the task. That error means a retry callback in the stored payload is gone from the code base. The claim script has already renewed the deadline in the running set, so the entry stays there. A later pass claims the same id and logs the same error. The log repeats every CLAIM_TTL (60 seconds by default).
One part is missing. The task stays in the running set, and the inspector disables the dequeue action on the Running tab (check_action returns False for dequeue on RUNNING). An operator who sees the error cannot clear or requeue that task.
Options:
- Let the inspector clear a running task after its lease expires.
- Give the broker a terminal action for a payload whose retry callback is gone. Deletion is one option. A quarantine segment, or a failed entry that carries the raw id and the read error, is another.
Reference: threadmill/backends/redis.py (_reap_running_queue).
- 主要语言
- Python
- 星标
- 19
- 派生
- 1
- 平均合并
- 14 小时 39 分钟
- 30 天内合并 PR
- 21
环境准备
- 没有 Dockerfile 或 Docker Compose 文件
- 没有 Pull Request 模板
- 阅读贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
codingjoe/threadmill 的其他 Issue
-
Add worker pool telemetry可能重新可做 @codingjoe 于 100 天前认领,目前没有进行中的 PR。 未关闭enhancement
codingjoe/threadmill#18 · 已指派 1 人 ·
维护者通常 1 天内回复
查看 codingjoe/threadmill 的全部 Issue
相似的 Issue
-
难度 2/5 1-3 小时 新手友好度 68/100
pyjanitor-devs/pyjanitor#1758 ·
维护者通常 1 天内回复
-
bug ready for review
难度 2/5 1-3 小时 新手友好度 86/100
odysseus-dev/odysseus#6641 ·
维护者通常 1 天内回复
-
bug
难度 2/5 1-3 小时 新手友好度 76/100
happypawspillaro/happypaws#78 ·
维护者通常 4 天内回复
-
pydanty:is-working
难度 2/5 1-3 小时 新手友好度 82/100
pydantic/pydantic-ai#10020 ·
维护者通常 1 天内回复
-
stdlib type-bug
难度 2/5 1-3 小时 新手友好度 68/100
python/cpython#159044 · 4 条评论 ·
维护者通常 1 天内回复