Windows contributor DX: bun run check, setup and release:test fail on Windows

未关闭
#260 3 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

还没有人认领这个 Issue。

评估

难度
4/5
预计耗时
3-5 天
新手友好度
45/100
Issue 类型
缺陷
描述清晰度
描述清楚
活跃度
活跃
技术栈
bash, bun, github-actions, python, rust, shell

调研方向

The first stop is package.json: every script that calls scripts/*.sh directly needs a bash prefix (the failing one is check → scripts/check-skills.sh), and the TS release tests that spawn a script need the same prefix. Then read setup.sh for the Linux hints and add a MINGW/MSYS branch covering MSVC Build Tools, WebView2, Git Bash and actionlint/zizmor, plus a Windows section in docs/contributing.md. Add a Windows CI job running bun run check without Rust; done means a fresh Windows 11 machine gets rc=0 from bun run setup through bun run check.

由索引模型根据 Issue 内容生成。

描述

area: ci priority: 2 normal status: confirmed type: chore

Observed on one Windows 11 machine (Git Bash, Bun, WSL installed) while gating #259 (gate note: https://github.com/codeatlasdev/atlas/pull/259#issuecomment-6882316955). The release:test failures also happen on main, so they are a pre-existing Windows break, not caused by #259. Causes marked "inferred" were not traced to Bun source.

Contributors on Windows cannot run the repo's own gate today. Found while gating #259 on Windows 11 (Git Bash + Bun):

What breaks

  • bun run check stops after cargo-deny: scripts/check-skills.sh fails with bun: unknown error. Inferred: Bun's script runner on Windows does not execute a .sh file by path (observed: bun: unknown error and EFTYPE uv_spawn). Same for every script that calls scripts/*.sh directly: setup, desktop:dev, desktop:build, lint:workflows, mobile:check, release:*, sweep, icons:dev.
  • release:test: 38 failures with EFTYPE: inappropriate file type or format, uv_spawn, identical on main: the TS tests Bun.spawnSync([script]) on .sh helpers; python3 is not the Windows name (python/py).
  • lint:workflows: actionlint/zizmor not installed and setup.sh does not say how on Windows.
  • setup.sh has hints for Linux packages only; nothing for Windows (WebView2, MSVC Build Tools, cargo-xwin not needed locally, etc.).
  • CI job rust-windows builds and tests Rust, but no CI job runs the scripts or bun run check on Windows, so this regresses silently.

Works by hand: bash scripts/check-skills.sh, bun run desktop:check (3199 tests), Rust fmt/clippy/nextest (1920 tests).

Proposal

  1. Every package.json script runs shell scripts as bash scripts/x.sh (Git Bash is already required for the repo); TS tests spawn ["bash", script]; Python via python3 || python.
  2. setup.sh detects Windows (uname -s MINGW/MSYS) and checks/hints: MSVC Build Tools, WebView2 runtime, Git Bash, cargo nextest, cargo deny, actionlint + zizmor via winget/scoop.
  3. docs/contributing.md: a "Windows" section (prereqs, bun run desktop:dev, what is macOS-only: agent instances, Lab, mirror).
  4. CI: a Windows job running bun run check minus the Rust part (already covered), so script breakage on Windows turns CI red.
  5. Optional later: port the most used scripts (setup, check-changed, heavy) to Bun TS so they need no bash at all.

Done when

A fresh Windows 11 machine with Git, Rust, Bun goes bun run setup → bun run check → rc=0, and CI enforces it.

主要语言
Rust
星标
3
派生
1
平均合并
9 小时 51 分钟
30 天内合并 PR
310

环境准备

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

codeatlasdev/atlas 的其他 Issue

查看 codeatlasdev/atlas 的全部 Issue

相似的 Issue

更多 Rust Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。