Windows contributor DX: bun run check, setup and release:test fail on Windows

Aperta
#260 3 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
4/5
Tempo stimato
3-5 giorni
Idoneità per principianti
45/100
Tipo di issue
Bug
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
bash, bun, github-actions, python, rust, shell

Direzione di ricerca

The first stop is package.json: every script that calls scripts/*.sh directly needs a bash prefix (the failing one is check → scripts/check-skills.sh), and the TS release tests that spawn a script need the same prefix. Then read setup.sh for the Linux hints and add a MINGW/MSYS branch covering MSVC Build Tools, WebView2, Git Bash and actionlint/zizmor, plus a Windows section in docs/contributing.md. Add a Windows CI job running bun run check without Rust; done means a fresh Windows 11 machine gets rc=0 from bun run setup through bun run check.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

area: ci priority: 2 normal status: confirmed type: chore

Observed on one Windows 11 machine (Git Bash, Bun, WSL installed) while gating #259 (gate note: https://github.com/codeatlasdev/atlas/pull/259#issuecomment-6882316955). The release:test failures also happen on main, so they are a pre-existing Windows break, not caused by #259. Causes marked "inferred" were not traced to Bun source.

Contributors on Windows cannot run the repo's own gate today. Found while gating #259 on Windows 11 (Git Bash + Bun):

What breaks

  • bun run check stops after cargo-deny: scripts/check-skills.sh fails with bun: unknown error. Inferred: Bun's script runner on Windows does not execute a .sh file by path (observed: bun: unknown error and EFTYPE uv_spawn). Same for every script that calls scripts/*.sh directly: setup, desktop:dev, desktop:build, lint:workflows, mobile:check, release:*, sweep, icons:dev.
  • release:test: 38 failures with EFTYPE: inappropriate file type or format, uv_spawn, identical on main: the TS tests Bun.spawnSync([script]) on .sh helpers; python3 is not the Windows name (python/py).
  • lint:workflows: actionlint/zizmor not installed and setup.sh does not say how on Windows.
  • setup.sh has hints for Linux packages only; nothing for Windows (WebView2, MSVC Build Tools, cargo-xwin not needed locally, etc.).
  • CI job rust-windows builds and tests Rust, but no CI job runs the scripts or bun run check on Windows, so this regresses silently.

Works by hand: bash scripts/check-skills.sh, bun run desktop:check (3199 tests), Rust fmt/clippy/nextest (1920 tests).

Proposal

  1. Every package.json script runs shell scripts as bash scripts/x.sh (Git Bash is already required for the repo); TS tests spawn ["bash", script]; Python via python3 || python.
  2. setup.sh detects Windows (uname -s MINGW/MSYS) and checks/hints: MSVC Build Tools, WebView2 runtime, Git Bash, cargo nextest, cargo deny, actionlint + zizmor via winget/scoop.
  3. docs/contributing.md: a "Windows" section (prereqs, bun run desktop:dev, what is macOS-only: agent instances, Lab, mirror).
  4. CI: a Windows job running bun run check minus the Rust part (already covered), so script breakage on Windows turns CI red.
  5. Optional later: port the most used scripts (setup, check-changed, heavy) to Bun TS so they need no bash at all.

Done when

A fresh Windows 11 machine with Git, Rust, Bun goes bun run setup → bun run check → rc=0, and CI enforces it.

Lingua principale
Rust
Stelle
3
Fork
1
Merge medio
9h 51m
PR unite (30g)
310

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di codeatlasdev/atlas

Tutte le issue di codeatlasdev/atlas

Issue simili

Altre issue su Rust

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.