Proposal: Abandon or change the way we use greenkeeper
还没有人认领这个 Issue。
评估
- 难度
- 5/5
- 预计耗时
- 一周以上
- 新手友好度
- 25/100
- Issue 类型
- 功能
- 描述清晰度
- 需要澄清
- 活跃度
- 停滞
- 技术栈
- javascript
- 领域
- tooling
调研方向
首先审查仓库的 Greenkeeper 设置和 yarn.lock 工作流,以及此处描述的 ember-cli 依赖行为。确定 Greenkeeper 是否可以忽略相关软件包,或者项目是否应放弃使用它;确定了双方认可的方法和相应的依赖更新配置后,即表示完成。
由索引模型根据 Issue 内容生成。
描述
Problem
Greenkeeper is creating a huge amount of PRs which, while in most cases, would be useful to keep dependencies up to date, in the case of a project using ember-cli, often cause unnecessary work.
The problem is, ember-cli is a bundle of packages and greenkeeper creates an update PR for each individual package in that bundle. An example is
https://github.com/code-corps/code-corps-ember/pull/1269
We do not want to update ember-source directly. We want to update ember-cli and then, if ember-cli decides we also need to update ember-source as we run ember init that's fine. Otherwise, ember-cli is the one telling us which packages it's dependent on. If anything, updating cli dependencies ourselves might cause issues.
In addition to that, greenkeeper is not setup to work with yarn. For each PR it creates we need to
- pull latest develop
- run
git rebase origin/develop - run
yarn install(this modifiesyarn.lock) - commit amend the modified file
- run
git push --force-with-lease - wait for the build
- review-approve and merge, or force merge
And really, the reasoning is, we want package updates as soon as possible. I don't really see the benefit in it.
I believe, if we opted to use a package, the assumption is, that package was desirable "as is", not in some soon to be updated version. Sure, we want our stuff up to date, but jumping on every minor version as soon as it's out more often than not means we instead get bugs.
Proposal 1 - Abandon greenkeeper
I believe a more cost-effective flow is:
- keep ember-cli up to date, with its dependencies
- if a non-core cli addon has deprecations after ember-cli is up to date, create an issue for it and keep updating it as now versions come out, until the deprecation is resolved
- for non-cli addons, if we're using them as they are, they're good enough. we periodically can update if there's a benefit, but otherwise, there's no need.
Proposal 2 - Change the way we use greenkeeper
I'm hoping there is a way to configure greenkeeper to not update specified packages. If we went in that direction, we could make a list of ember-cli packages greenkeeper could then ignore, so we'd sort of get the "best of both worlds".
That being said, I'm not finding anything on the site or in the repository that could enable us to do so.
- 主要语言
- JavaScript
- 星标
- 120
- 派生
- 75
- PR 合并指标
- 30 天内没有已合并 PR
贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
code-corps/code-corps-ember 的其他 Issue
-
难度 2/5 1-3 小时 新手友好度 68/100
code-corps/code-corps-ember#1616 ·
-
难度 2/5 1-3 小时 新手友好度 65/100
code-corps/code-corps-ember#1613 ·
-
难度 2/5 1-3 小时 新手友好度 72/100
code-corps/code-corps-ember#1612 ·
-
Difficulty: Medium Skill: ember-cli-page-object
难度 2/5 1-3 小时 新手友好度 62/100
code-corps/code-corps-ember#1063 · 1 个 reaction ·
-
greenkeeper
难度 3/5 1-2 天 新手友好度 25/100
code-corps/code-corps-ember#1765 · 1 条评论 ·
查看 code-corps/code-corps-ember 的全部 Issue
相似的 Issue
-
bug confirmed issue
难度 2/5 1-3 小时 新手友好度 75/100
open-webui/open-webui#30750 · 1 条评论 ·
-
难度 2/5 1-3 小时 新手友好度 75/100
-
难度 2/5 1-3 小时 新手友好度 70/100
-
难度 2/5 1-3 小时 新手友好度 75/100
-
Mend: dependency security vulnerability untriaged
难度 2/5 1-3 小时 新手友好度 70/100