Proposal: Abandon or change the way we use greenkeeper
Nadie ha tomado este issue todavía.
Evaluación
- Dificultad
- 5/5
- Tiempo estimado
- Más de una semana
- Aptitud para principiantes
- 25/100
- Tipo de issue
- Nueva funcionalidad
- Claridad
- Necesita aclaración
- Estado de actividad
- Estancado
- Stack tecnológico
- javascript
- Área
- tooling
Línea de trabajo
Comienza revisando la configuración de Greenkeeper y el flujo de trabajo de yarn.lock del repositorio, junto con el comportamiento de las dependencias de ember-cli descrito aquí. Determina si Greenkeeper puede ignorar los paquetes relevantes o si el proyecto debería abandonarlo; se considera terminado cuando haya un enfoque acordado y la configuración correspondiente para las actualizaciones de dependencias.
Escrito por el modelo de indexación a partir del texto del issue.
Descripción
Problem
Greenkeeper is creating a huge amount of PRs which, while in most cases, would be useful to keep dependencies up to date, in the case of a project using ember-cli, often cause unnecessary work.
The problem is, ember-cli is a bundle of packages and greenkeeper creates an update PR for each individual package in that bundle. An example is
https://github.com/code-corps/code-corps-ember/pull/1269
We do not want to update ember-source directly. We want to update ember-cli and then, if ember-cli decides we also need to update ember-source as we run ember init that's fine. Otherwise, ember-cli is the one telling us which packages it's dependent on. If anything, updating cli dependencies ourselves might cause issues.
In addition to that, greenkeeper is not setup to work with yarn. For each PR it creates we need to
- pull latest develop
- run
git rebase origin/develop - run
yarn install(this modifiesyarn.lock) - commit amend the modified file
- run
git push --force-with-lease - wait for the build
- review-approve and merge, or force merge
And really, the reasoning is, we want package updates as soon as possible. I don't really see the benefit in it.
I believe, if we opted to use a package, the assumption is, that package was desirable "as is", not in some soon to be updated version. Sure, we want our stuff up to date, but jumping on every minor version as soon as it's out more often than not means we instead get bugs.
Proposal 1 - Abandon greenkeeper
I believe a more cost-effective flow is:
- keep ember-cli up to date, with its dependencies
- if a non-core cli addon has deprecations after ember-cli is up to date, create an issue for it and keep updating it as now versions come out, until the deprecation is resolved
- for non-cli addons, if we're using them as they are, they're good enough. we periodically can update if there's a benefit, but otherwise, there's no need.
Proposal 2 - Change the way we use greenkeeper
I'm hoping there is a way to configure greenkeeper to not update specified packages. If we went in that direction, we could make a list of ember-cli packages greenkeeper could then ignore, so we'd sort of get the "best of both worlds".
That being said, I'm not finding anything on the site or in the repository that could enable us to do so.
- Lenguaje dominante
- JavaScript
- Estrellas
- 120
- Forks
- 75
- Métricas de merge de PR
- Sin PR fusionados en 30 d
Guía de contribución
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Más de code-corps/code-corps-ember
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 68/100
code-corps/code-corps-ember#1616 ·
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 65/100
code-corps/code-corps-ember#1613 ·
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 72/100
code-corps/code-corps-ember#1612 ·
-
Difficulty: Medium Skill: ember-cli-page-object
Dificultad 2/5 1-3 horas Aptitud para principiantes 62/100
code-corps/code-corps-ember#1063 · 1 reacción ·
-
greenkeeper
Dificultad 3/5 1-2 días Aptitud para principiantes 25/100
code-corps/code-corps-ember#1765 · 1 comentario ·
Todos los issues de code-corps/code-corps-ember
Issues similares
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 70/100
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 75/100
mksglu/context-mode#1200 ·
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 75/100
neondatabase/website#5944 ·
-
module: core
Dificultad 2/5 1-3 horas Aptitud para principiantes 75/100
bigbluebutton/bigbluebutton#25849 ·
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 75/100
jaegertracing/jaeger-ui#4506 ·