RFC: Is organization/project approval still relevant?
还没有人认领这个 Issue。
评估
- 难度
- 5/5
- 预计耗时
- 一周以上
- 新手友好度
- 20/100
- Issue 类型
- 功能
- 描述清晰度
- 需要澄清
- 活跃度
- 停滞
- 技术栈
- elixir
- 领域
- authorization, backend
调研方向
从 issue 中描述的组织和项目 index/show 操作以及邀请系统开始。将 keep、drop 和组合审批选项与现有的 approved 列进行比较;确定审批策略并就实现范围达成一致后,工作才算完成。
由索引模型根据 Issue 内容生成。
描述
We added an approved column to projects and organizations almost a year ago. I'm not sure if we had the organization invite system in mind when adding it.
The way I see it, the columns could still be relevant.
Keep the columns
- once a user creates an organization and a project, the ember app tells them the two "still need to be approved by an administrator"
- the ember app indicates/shows reduced UI for unapproved projects/organizations
There is then the question of how to most effectively filter out unapproved records
Option A
- the index actions for organizations and projects should only list approved items, if no filters are applied
- the show action and the index actions when filtered to specific ids, should still list all records
- that means unapproved records are unlisted, but can still be reached by direct url, where they are shown in a reduced state
Option B
- index and show should be scoped to current user
- owner can see all approved and their own unapproved records
- regular user can only see approved records
- this means unapproved records are not reachable by regular users
Drop the columns
- Organizations can only be created by admins or via invites - no changes other than normal milestone changes.
- Project creation creates a problem of organization owner being able to create multiple projects once they create the organization. We could fix by
- adding a project limit of 1 to each organization
- we can always manually increase the limit for select organizations, if we want to
A potential problem with dropping the approved columns will be that the user could always do something bad, even a user we trust enough to send an invite to.
Once (hopefully) CodeCorps gets big enough, we will probably have direct org/project creation, not via invites. We'll need an approval system at that point anyway.
We could also do both
We could keep the columns in, but auto-approve an organization created via invite and also maybe auto-approve the first project created by such organization.
- 主要语言
- Elixir
- 星标
- 234
- 派生
- 82
- PR 合并指标
- 30 天内没有已合并 PR
贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
code-corps/code-corps-api 的其他 Issue
-
难度 5/5 一周以上 新手友好度 15/100
code-corps/code-corps-api#1385 ·
-
难度 3/5 1-2 天 新手友好度 25/100
code-corps/code-corps-api#1384 ·
-
难度 4/5 3-5 天 新手友好度 35/100
code-corps/code-corps-api#1383 · 2 条评论 ·
-
难度 3/5 1-2 天 新手友好度 35/100
code-corps/code-corps-api#1382 · 2 条评论 ·
-
Difficulty: Medium Skill: Elixir Time: 4 hours
code-corps/code-corps-api#1372 · 3 条评论 · 已指派 1 人 ·
查看 code-corps/code-corps-api 的全部 Issue
相似的 Issue
-
难度 2/5 1-3 小时 新手友好度 75/100
carverauto/serviceradar#4596 ·
-
难度 2/5 1-3 小时 新手友好度 75/100
-
bug
难度 2/5 1-3 小时 新手友好度 65/100
-
难度 2/5 1-3 小时 新手友好度 75/100
agentjido/jido_harness#80 ·
-
难度 2/5 1-3 小时 新手友好度 70/100
sevenseacat/cinder#235 ·