Hacktoberfest 2026:维护者为十月标记出来的 issue,仍然开放、适合新手。 浏览 Hacktoberfest issue

RFC: Is organization/project approval still relevant?

未关闭
#1,231 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

还没有人认领这个 Issue。

评估

难度
5/5
预计耗时
一周以上
新手友好度
20/100
Issue 类型
功能
描述清晰度
需要澄清
活跃度
停滞
技术栈
elixir

调研方向

从 issue 中描述的组织和项目 index/show 操作以及邀请系统开始。将 keep、drop 和组合审批选项与现有的 approved 列进行比较;确定审批策略并就实现范围达成一致后,工作才算完成。

由索引模型根据 Issue 内容生成。

描述

needs clarification question RFC

We added an approved column to projects and organizations almost a year ago. I'm not sure if we had the organization invite system in mind when adding it.

The way I see it, the columns could still be relevant.

Keep the columns

  • once a user creates an organization and a project, the ember app tells them the two "still need to be approved by an administrator"
  • the ember app indicates/shows reduced UI for unapproved projects/organizations

There is then the question of how to most effectively filter out unapproved records

Option A

  • the index actions for organizations and projects should only list approved items, if no filters are applied
  • the show action and the index actions when filtered to specific ids, should still list all records
  • that means unapproved records are unlisted, but can still be reached by direct url, where they are shown in a reduced state

Option B

  • index and show should be scoped to current user
    • owner can see all approved and their own unapproved records
    • regular user can only see approved records
  • this means unapproved records are not reachable by regular users

Drop the columns

  • Organizations can only be created by admins or via invites - no changes other than normal milestone changes.
  • Project creation creates a problem of organization owner being able to create multiple projects once they create the organization. We could fix by
    • adding a project limit of 1 to each organization
    • we can always manually increase the limit for select organizations, if we want to

A potential problem with dropping the approved columns will be that the user could always do something bad, even a user we trust enough to send an invite to.

Once (hopefully) CodeCorps gets big enough, we will probably have direct org/project creation, not via invites. We'll need an approval system at that point anyway.

We could also do both

We could keep the columns in, but auto-approve an organization created via invite and also maybe auto-approve the first project created by such organization.

主要语言
Elixir
星标
234
派生
82
PR 合并指标
30 天内没有已合并 PR

贡献指南

打开贡献指南

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

code-corps/code-corps-api 的其他 Issue

查看 code-corps/code-corps-api 的全部 Issue

相似的 Issue

更多 Elixir Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。