RFC: Is organization/project approval still relevant?

Issueで説明されている組織とプロジェクトのインデックス／表示アクション、および招待システムから始めます。keep、drop、combined の承認オプションを既存の approved カラムと比較します。承認ポリシーが決定され、実装範囲について合意されれば完了です。

We added an approved column to projects and organizations almost a year ago. I'm not sure if we had the organization invite system in mind when adding it.

The way I see it, the columns could still be relevant.

Keep the columns

• once a user creates an organization and a project, the ember app tells them the two "still need to be approved by an administrator"
• the ember app indicates/shows reduced UI for unapproved projects/organizations

There is then the question of how to most effectively filter out unapproved records

Option A

• the index actions for organizations and projects should only list approved items, if no filters are applied
• the show action and the index actions when filtered to specific ids, should still list all records
• that means unapproved records are unlisted, but can still be reached by direct url, where they are shown in a reduced state

Option B

• index and show should be scoped to current user
  • owner can see all approved and their own unapproved records
  • regular user can only see approved records
• this means unapproved records are not reachable by regular users

Drop the columns

• Organizations can only be created by admins or via invites - no changes other than normal milestone changes.
• Project creation creates a problem of organization owner being able to create multiple projects once they create the organization. We could fix by
  • adding a project limit of 1 to each organization
  • we can always manually increase the limit for select organizations, if we want to

A potential problem with dropping the approved columns will be that the user could always do something bad, even a user we trust enough to send an invite to.

Once (hopefully) CodeCorps gets big enough, we will probably have direct org/project creation, not via invites. We'll need an approval system at that point anyway.

We could also do both

We could keep the columns in, but auto-approve an organization created via invite and also maybe auto-approve the first project created by such organization.