voltra CLI pulls in @xmldom/xmldom 0.7, which has known high-severity vulnerabilities

未关闭
#375 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

还没有人认领这个 Issue。

评估

难度
4/5
预计耗时
3-5 天
新手友好度
30/100
Issue 类型
重构
描述清晰度
基本清楚
活跃度
活跃
技术栈
nodejs, typescript
领域
cli, security

调研方向

Start with packages/cli/package.json and run pnpm why @xmldom/xmldom in the repo to see the whole chain from @bacons/xcode through @expo/plist. Then read packages/cli/src/platforms/ios/xcode.ts to see how narrowly the parsed project files are used. Both proposed fixes are open-ended — wait for an upstream @bacons/xcode release or swap the pbxproj library — so confirm the choice with a maintainer before starting; done means pnpm audit no longer reports a high finding that reaches published CLI users.

由索引模型根据 Issue 内容生成。

描述

The voltra CLI (packages/cli) depends on @bacons/xcode@^1.0.0-alpha.33, which depends on @expo/plist@^0.0.18. A caret range on 0.0.x pins it to 0.0.18 exactly, and that version requires @xmldom/xmldom@~0.7.0. There is no patched 0.7 release, so installing the CLI brings in @xmldom/xmldom 0.7.13, which pnpm audit and Dependabot flag with several high-severity advisories. After #370, this is the only high finding left that reaches users.

The CLI uses @bacons/xcode to open and edit the user's own Xcode project (packages/cli/src/platforms/ios/xcode.ts), so the vulnerable XML parsing only ever sees files from that project. The practical risk is low.

Ways to fix it:

  • A release of @bacons/xcode on a current @expo/plist. The 0.10.x line uses @xmldom/xmldom ^0.8.8, and alpha.33 is the latest @bacons/xcode release.
  • Moving the CLI to a different pbxproj library.

A pnpm.overrides entry wouldn't help, because it only changes this repository's lockfile, not what users install.

主要语言
TypeScript
星标
864
派生
51
平均合并
2 天 2 小时
30 天内合并 PR
10

环境准备

  • 没有 Dockerfile 或 Docker Compose 文件
  • 没有 Pull Request 模板
  • 阅读贡献指南

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

callstackincubator/voltra 的其他 Issue

查看 callstackincubator/voltra 的全部 Issue

相似的 Issue

更多 TypeScript Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。