voltra CLI pulls in @xmldom/xmldom 0.7, which has known high-severity vulnerabilities

Abierto
#375 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
4/5
Tiempo estimado
3-5 días
Aptitud para principiantes
30/100
Tipo de issue
Refactorización
Claridad
Bastante claro
Estado de actividad
Activo
Stack tecnológico
nodejs, typescript
Área
cli, security

Línea de trabajo

Start with packages/cli/package.json and run pnpm why @xmldom/xmldom in the repo to see the whole chain from @bacons/xcode through @expo/plist. Then read packages/cli/src/platforms/ios/xcode.ts to see how narrowly the parsed project files are used. Both proposed fixes are open-ended — wait for an upstream @bacons/xcode release or swap the pbxproj library — so confirm the choice with a maintainer before starting; done means pnpm audit no longer reports a high finding that reaches published CLI users.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

The voltra CLI (packages/cli) depends on @bacons/xcode@^1.0.0-alpha.33, which depends on @expo/plist@^0.0.18. A caret range on 0.0.x pins it to 0.0.18 exactly, and that version requires @xmldom/xmldom@~0.7.0. There is no patched 0.7 release, so installing the CLI brings in @xmldom/xmldom 0.7.13, which pnpm audit and Dependabot flag with several high-severity advisories. After #370, this is the only high finding left that reaches users.

The CLI uses @bacons/xcode to open and edit the user's own Xcode project (packages/cli/src/platforms/ios/xcode.ts), so the vulnerable XML parsing only ever sees files from that project. The practical risk is low.

Ways to fix it:

  • A release of @bacons/xcode on a current @expo/plist. The 0.10.x line uses @xmldom/xmldom ^0.8.8, and alpha.33 is the latest @bacons/xcode release.
  • Moving the CLI to a different pbxproj library.

A pnpm.overrides entry wouldn't help, because it only changes this repository's lockfile, not what users install.

Lenguaje dominante
TypeScript
Estrellas
864
Forks
51
Merge medio
2 d 2 h
PR fusionados (30 d)
10

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de callstackincubator/voltra

Todos los issues de callstackincubator/voltra

Issues similares

Más issues de TypeScript

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.