ScriptManager caches the rejected promise when a resolver throws, so loadScript/prefetchScript never retry

未关闭
  • 哪里不对？
#1,506 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 2 天内回复

@linhh-phv 已经在做这个了。

开始于 2026年10月20日。

  • #1507 来自 @linhh-phv —— 未关闭

评估

难度
2/5
预计耗时
1-3 小时
新手友好度
35/100
Issue 类型
缺陷
描述清晰度
描述清楚
活跃度
停滞
技术栈
react-native, typescript, webpack
领域
tooling

调研方向

Read the loadScript and prefetchScript implementations in ScriptManager and the linked ScriptManager.test.ts reproduction. Check how each method handles a rejected resolveScript call and how its cached promise is cleaned up. Done when the resolver is called again on a retry after a resolver failure, and both reproduction tests pass.

由索引模型根据 Issue 内容生成。

描述

Describe the bug

If a script resolver throws, ScriptManager keeps the rejected promise in scriptsPromises. Every later loadScript / prefetchScript call for the same script returns that same error and never calls the resolvers again. The only way out is to restart the app.

In loadScript and prefetchScript, resolveScript is awaited before the try / finally that removes the entry from scriptsPromises:

const loadProcess = async () => {
  let script = await this.resolveScript(/* ... */); // a throw here skips the finally below

  try {
    // ...
  } catch (error) {
    // ...
  } finally {
    // should delete script promise even script failed
    delete this.scriptsPromises[uniqueId];
  }
};

this.scriptsPromises[uniqueId] = loadProcess();

So the "delete even if it failed" path only runs for loading errors, not for resolving errors. The same pattern is in prefetchScript. It also affects loadScript after a failed prefetchScript, because loadScript awaits the cached prefetch promise and rethrows its error.

Expected: after a resolver error (e.g. the device was offline while the resolver fetched the script URL), the next loadScript call runs the resolvers again, the same way it already retries after a failed native load.

Actual: the next loadScript calls reject right away with the first error, even after the network is back. In our app a user who opened a mini app while offline could not open it again until they killed and reopened the app. A retry button on an error boundary or React.lazy remount did not help.

System Info
React Native 0.79.7 (New Architecture, Hermes)
@callstack/repack 5.2.5, bundler webpack 5, Module Federation v1
iOS and Android, release builds
Re.Pack Version

5.2.5. The code is unchanged in 5.4.2 and on main (32c32c0).

Reproduction

https://github.com/linhh-phv/repack/blob/fix/script-manager-retry-after-resolve-failure/packages/repack/src/modules/ScriptManager/__tests__/ScriptManager.test.ts. The two tests should retry loadScript after resolver failure and should retry prefetchScript after resolver failure fail on main and pass with the fix.

Steps to reproduce

  1. Add a resolver that rejects once, then resolves:

    const resolver = jest
  .fn()
  .mockRejectedValueOnce(new Error('Network request failed'))
  .mockImplementation(async (scriptId) => ({ url: Script.getRemoteURL(scriptId) }));
ScriptManager.shared.addResolver(resolver);

  2. await ScriptManager.shared.loadScript('miniApp') rejects with Network request failed, as expected.

  3. Call await ScriptManager.shared.loadScript('miniApp') again: it rejects with the same error and resolver was called only once.

In an app: make the resolver depend on the network (for example, fetch the version or URL of a remote), open a federated remote while offline, turn the network back on, then try to open it again.

I have a fix ready and will open a PR: delete the cached promise when resolveScript throws, then rethrow.

主要语言
TypeScript
星标
1.9k
派生
177
平均合并
2 天 10 小时
30 天内合并 PR
23

环境准备

  • 没有 Dockerfile 或 Docker Compose 文件
  • 没有 Pull Request 模板
  • 阅读贡献指南

从这里开始

  1. 先读完整个 Issue，再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库，在一个分支上完成修改。
  4. 提交 Pull Request，并在描述里引用这个 Issue 编号。

callstack/repack 的其他 Issue

查看 callstack/repack 的全部 Issue

相似的 Issue

更多 TypeScript Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。